Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes v1.32 Release Notes final draft #2691

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Dec 11, 2024

Fork of #2689 , to proceed with the rebase + merge of the Kubernetes v1.32 Release Notes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-team Issues or PRs related to the release-team subproject needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2024
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Dec 11, 2024

cc @satyampsoni @katcosgrove @sftim : this includes the files as they were after undergoing all the reviews.

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Dec 11, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@fsmunoz: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link
Contributor

sftim commented Dec 11, 2024

/lgtm

This looks right to me.
/hold

@fsmunoz you are welcome to unhold this if you think my LGTM here counts. I'm not formally in the release SIG / release team.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Dec 11, 2024

@sftim it does count ty. We're still tackling some small issues but they do not affect the work done so far.

@sftim
Copy link
Contributor

sftim commented Dec 11, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Dec 11, 2024

/kind cleanup
/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
Vyom-Yadav and others added 2 commits December 11, 2024 21:22
Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Dec 11, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@fsmunoz: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@npolshakova
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, npolshakova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

/hold cancel

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Dec 11, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 94c76df into kubernetes:master Dec 11, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants