Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arch linux installer to v0.12.2 #742

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Oct 21, 2016

I added the arch linux minikube package repository as a submodule because that is how it is pushed to the arch AUR. I don't think there should be any trouble pulling the minikube repo with this, but I will verify

@r2d4
Copy link
Contributor Author

r2d4 commented Oct 21, 2016

ref #737

@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 33.35% (diff: 100%)

Merging #742 into master will not change coverage

@@             master       #742   diff @@
==========================================
  Files            43         43          
  Lines          1847       1847          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            616        616          
  Misses         1114       1114          
  Partials        117        117          

Powered by Codecov. Last update 36cb442...bc73a5f

@r2d4 r2d4 changed the title Update arch linux installer to v0.12.0 WIP: Update arch linux installer to v0.12.0 Oct 21, 2016
@dlorenc
Copy link
Contributor

dlorenc commented Oct 22, 2016

What repo are you pointing this to?

@r2d4
Copy link
Contributor Author

r2d4 commented Oct 25, 2016

The installer is hosted in its own repo on the arch AUR

https://aur.archlinux.org/minikube.git

From
https://aur.archlinux.org/packages/minikube/

To update, you create a commit with the upgrade and push it to that repo.

It looks like I didn't set up the submodule correctly though so I'll try again

On Oct 22, 2016, at 10:13 AM, dlorenc notifications@github.com wrote:

What repo are you pointing this to?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@r2d4 r2d4 changed the title WIP: Update arch linux installer to v0.12.0 Update arch linux installer to v0.12.2 Nov 1, 2016
@r2d4
Copy link
Contributor Author

r2d4 commented Nov 1, 2016

ref #787

@r2d4
Copy link
Contributor Author

r2d4 commented Nov 1, 2016

I added the submodule pointing to

url = https://aur.archlinux.org/minikube.git

which is the public-readonly git repository. However, in order to push to the repo - you need to overwrite that url locally by running

git config submodule.archlinux.url ssh://aur@aur.archlinux.org/minikube.git

Copy link
Contributor

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this to our docs?

@r2d4 r2d4 merged commit 061d2d0 into kubernetes:master Nov 3, 2016
@r2d4 r2d4 deleted the archlinux branch November 3, 2016 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants