remove e2e run before cluster upgrade #9988
Conversation
|
GCE e2e build/test passed for commit b4a26997192aba469cfd064d184a7b5419d118b7. |
| echo "Tests on initial version succeeded. Running the checked master upgrade." | ||
| go run "$(dirname $0)/e2e.go" -v --test --test_args='--ginkgo.focus=Skipped.*Cluster\supgrade.*gce-upgrade' -check_version_skew=false | ||
| echo "Master upgrade complete. Running e2e on the upgraded cluster." | ||
| go run "$(dirname $0)/e2e.go" -v -build -up -version="" -test -check_version_skew=false |
There was a problem hiding this comment.
So I think you want to run e2e tests of the old version?
In this scenario, you've upgraded the master, but the nodes are still at the old version. If the e2e tests at the new version test a new feature that doesn't exist in the old version, they'll fail.
There was a problem hiding this comment.
For this test, the old version is the new version. Currently (and since it was added), it deploys a locally built version and upgrades with the locally built version.
mikedanese
force-pushed
the
upgrade-pre-e2e
branch
from
b4a2699 to
dbb47fe
Compare
|
GCE e2e build/test passed for commit dbb47fe. |
|
So this is just meant to be run locally, right? As a shortcut for building, running master upgrade (to itself), then running e2es? I guess I'm wondering what part of #8081 this solves? |
|
Yes this is to update the local upgrade-test helper script to match what jenkins does. |
|
This was in parity with jenkins before the recent discussion in #8081 but not after removing the first e2e run. I would say local helper scripts are part of the master upgrade harness. |
|
Ack, thanks for the explanation. |
mbforbes
added
the
lgtm
| echo "Tests on initial version succeeded. Running the checked master upgrade." | ||
| go run "$(dirname $0)/e2e.go" -v --test --test_args='--ginkgo.focus=Skipped.*Cluster\supgrade.*gce-upgrade' -check_version_skew=false | ||
| echo "Master upgrade complete. Running e2e on the upgraded cluster." | ||
| go run "$(dirname $0)/e2e.go" -v -version="" -test -check_version_skew=false |
There was a problem hiding this comment.
do you need -version="" here?
There was a problem hiding this comment.
do you want to specify the string of only the tests that aren't flaky?
remove e2e run before cluster upgrade
part of #8081