Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give PATCH operations a better output in Swagger #9962

Merged
merged 2 commits into from
Jun 18, 2015

Conversation

smarterclayton
Copy link
Contributor

Instead of "string", create an object to hold the type so
that we can document it in the future. Return a versioned
type.

@nikhiljindal
Copy link
Contributor

Thanks a lot @smarterclayton.
This helps in fixing #9964 as well :)

@k8s-bot
Copy link

k8s-bot commented Jun 17, 2015

GCE e2e build/test passed for commit a1374ea5f70f8e08b71b665deba4fd8192d5153c.

@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2015
@nikhiljindal
Copy link
Contributor

Note for oncall: This is allowed for v1 since it helps in fixing #9964

@k8s-bot
Copy link

k8s-bot commented Jun 18, 2015

GCE e2e build/test failed for commit 0fbc4a8f78dca6e70b540165b7347c9bf10f05d3.

@k8s-bot
Copy link

k8s-bot commented Jun 18, 2015

GCE e2e build/test passed for commit 21d6feb.

satnam6502 added a commit that referenced this pull request Jun 18, 2015
Give PATCH operations a better output in Swagger
@satnam6502 satnam6502 merged commit de457c3 into kubernetes:master Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants