Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote huge page storage medium size to GA #99144

Merged
merged 1 commit into from
Jul 8, 2021
Merged

promote huge page storage medium size to GA #99144

merged 1 commit into from
Jul 8, 2021

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Feb 17, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR promotes support for multiple size huge pages to GA.
This feature was enabled by default in Kubernetes since v.19 and haven't got any complains since then, so it should be ready for promotion.

Does this PR introduce a user-facing change?

The `HugePageStorageMediumSize` feature has been promoted to GA, allowing unconditional usage of multiple sizes huge page resources on a container level.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet labels Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 17, 2021
@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 17, 2021

/retest

@bart0sh bart0sh force-pushed the PR0094-promote-HugePageStorageMediumSize-to-GA branch 2 times, most recently from f761b1b to a12b2d7 Compare February 17, 2021 11:03
@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 17, 2021

/cc @derekwaynecarr

@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 17, 2021

/cc @odinuge

@k8s-ci-robot k8s-ci-robot requested a review from odinuge February 17, 2021 11:06
@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 17, 2021

/cc @cynepco3hahue

@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 17, 2021

/test pull-kubernetes-e2e-kind-ipv6

odinuge
odinuge approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2021
@bart0sh
Copy link
Contributor Author

bart0sh commented Feb 17, 2021

/retest

ehashman
ehashman reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

The linked KEP (kubernetes/enhancements#1539) is not being tracked for this release.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@bart0sh
Copy link
Contributor Author

bart0sh commented May 27, 2021

@ehashman thank you for the explanation! This PR hopefully fixes the flakiness. I'll submit conformance PR after 2 weeks if test is green.

@bart0sh
Copy link
Contributor Author

bart0sh commented Jun 2, 2021

/assign @derekwaynecarr @dchen1107

derekwaynecarr
derekwaynecarr approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@derekwaynecarr derekwaynecarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

pkg/kubelet/config/common.go
AllowMultipleHugePageResources: utilfeature.DefaultFeatureGate.Enabled(features.HugePageStorageMediumSize),
}
if errs := validation.ValidatePodCreate(newPod, opts); len(errs) > 0 {
if errs := validation.ValidatePodCreate(newPod, validation.PodValidationOptions{}); len(errs) > 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this has been a useful pattern for injection validation options for similar changes to pod spec evolution.

@dims
Copy link
Member

dims commented Jul 7, 2021

/approve
/lgtm
/assign @liggitt @smarterclayton

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 7, 2021
@liggitt
Copy link
Member

liggitt commented Jul 7, 2021

/approve

for API validation bits

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, derekwaynecarr, dims, liggitt, odinuge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@ehashman
Copy link
Member

ehashman commented Jul 7, 2021

/retest

1 similar comment
@ehashman
Copy link
Member

ehashman commented Jul 7, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 36a7426 into kubernetes:master Jul 8, 2021
tengqm added a commit to tengqm/website that referenced this pull request Jul 8, 2021
@tengqm
Batch update feature gates for 1.22
b6c6b79 
Here is a second batch for feature gate updates in 1.22.

- EndpointSliceProxying  kubernetes/kubernetes#103451
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451
- LogarithmicScaleDown    kubernetes/kubernetes#101767
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- NodeSwapEnabled   kubernetes/kubernetes#102823
- DelegateFSGroupToCSIDriver   kubernetes/kubernetes#103244
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- StatefulSetAutoDeletePVC kubernetes/kubernetes#99378

Some of these needs more detailed documentation.
@tengqm tengqm mentioned this pull request Jul 8, 2021
Merged
tengqm added a commit to tengqm/website that referenced this pull request Jul 9, 2021
@tengqm
Batch update feature gates for 1.22
522539b 
Here is a second batch for feature gate updates in 1.22.

- EndpointSliceProxying  kubernetes/kubernetes#103451
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- NodeSwapEnabled   kubernetes/kubernetes#102823
- DelegateFSGroupToCSIDriver   kubernetes/kubernetes#103244
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- StatefulSetAutoDeletePVC kubernetes/kubernetes#99378

Some of these needs more detailed documentation.
tengqm added a commit to tengqm/website that referenced this pull request Jul 11, 2021
@tengqm
Batch update feature gates for 1.22
4a4f8fc 
Here is a second batch for feature gate updates in 1.22.

- CPUManagerPolicyOptions    kubernetes/kubernetes#101432
- ControllerManagerLeaderMigration  kubernetes/kubernetes#103533
- DelegateFSGroupToCSIDriver   kubernetes/kubernetes#103244
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- EndpointSliceProxying  kubernetes/kubernetes#103451
- EndpointSliceTerminatingCondition  kubernetes/kubernetes#103596
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- JobTrackingWithFinalizers   kubernetes/kubernetes#98817
  (also tracked in kubernetes#28841, can rebase).
- MemoryQoS   kubernetes/kubernetes#102970
- NodeSwap  kubernetes/kubernetes#102823, kubernetes/kubernetes#103553
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- StatefulSetAutoDeletePVC kubernetes/kubernetes#99378
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451

Some of these needs more detailed documentation.
tengqm added a commit to tengqm/website that referenced this pull request Jul 18, 2021
@tengqm
Batch update feature gates for 1.22
bee2491 
Here is a second batch for feature gate updates in 1.22.

- CPUManagerPolicyOptions    kubernetes/kubernetes#101432
- ControllerManagerLeaderMigration  kubernetes/kubernetes#103533
- DelegateFSGroupToCSIDriver   kubernetes/kubernetes#103244
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- EndpointSliceProxying  kubernetes/kubernetes#103451
- EndpointSliceTerminatingCondition  kubernetes/kubernetes#103596
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- JobTrackingWithFinalizers   kubernetes/kubernetes#98817
  (also tracked in kubernetes#28841, can rebase).
- MemoryQoS   kubernetes/kubernetes#102970
- NodeSwap  kubernetes/kubernetes#102823, kubernetes/kubernetes#103553
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- StatefulSetAutoDeletePVC kubernetes/kubernetes#99378
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451

Some of these needs more detailed documentation.
tengqm added a commit to tengqm/website that referenced this pull request Jul 21, 2021
@tengqm
Batch update feature gates for 1.22
fda406e 
Here is a second batch for feature gate updates in 1.22.

- CPUManagerPolicyOptions    kubernetes/kubernetes#101432
- ControllerManagerLeaderMigration  kubernetes/kubernetes#103533
- DelegateFSGroupToCSIDriver   kubernetes/kubernetes#103244
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- EndpointSliceProxying  kubernetes/kubernetes#103451
- EndpointSliceTerminatingCondition  kubernetes/kubernetes#103596
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- JobTrackingWithFinalizers   kubernetes/kubernetes#98817
  (also tracked in kubernetes#28841, can rebase).
- MemoryQoS   kubernetes/kubernetes#102970
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- StatefulSetAutoDeletePVC kubernetes/kubernetes#99378
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451

Some of these needs more detailed documentation.
tengqm added a commit to tengqm/website that referenced this pull request Jul 22, 2021
@tengqm
Batch update feature gates for 1.22
e1e87c2 
Here is a second batch for feature gate updates in 1.22.

- CPUManagerPolicyOptions    kubernetes/kubernetes#101432
- ControllerManagerLeaderMigration  kubernetes/kubernetes#103533
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- EndpointSliceProxying  kubernetes/kubernetes#103451
- EndpointSliceTerminatingCondition  kubernetes/kubernetes#103596
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- JobTrackingWithFinalizers   kubernetes/kubernetes#98817
  (also tracked in kubernetes#28841, can rebase).
- MemoryQoS   kubernetes/kubernetes#102970
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- StatefulSetAutoDeletePVC kubernetes/kubernetes#99378
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451

Some of these needs more detailed documentation.
tengqm added a commit to tengqm/website that referenced this pull request Jul 23, 2021
@tengqm
Batch update feature gates for 1.22
5239adf 
Here is a second batch for feature gate updates in 1.22.

- CPUManagerPolicyOptions    kubernetes/kubernetes#101432
- ControllerManagerLeaderMigration  kubernetes/kubernetes#103533
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- EndpointSliceProxying  kubernetes/kubernetes#103451
- EndpointSliceTerminatingCondition  kubernetes/kubernetes#103596
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- JobTrackingWithFinalizers   kubernetes/kubernetes#98817
  (also tracked in kubernetes#28841, can rebase).
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451

Some of these needs more detailed documentation.
@bart0sh bart0sh mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@derekwaynecarr derekwaynecarr derekwaynecarr approved these changes

@odinuge odinuge odinuge approved these changes

@dims dims Awaiting requested review from dims

@cynepco3hahue cynepco3hahue Awaiting requested review from cynepco3hahue

Assignees

@dims dims

@liggitt liggitt

@smarterclayton smarterclayton

@odinuge odinuge

@cynepco3hahue cynepco3hahue

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.22
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.