Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Logging migration: modify volume and container part logs o… #98850

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Structured Logging migration: modify volume and container part logs o… #98850

merged 1 commit into from
Mar 17, 2021

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 7, 2021 •
edited by liggitt
Loading

…f kubelet.

Signed-off-by: JunYang yang.jun22@zte.com.cn

What type of PR is this?
/kind feature

What this PR does / why we need it:
Structured Logging migration: modify volume and container part logs of kubelet.
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yangjunmyfm192085. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2021
@matthyx matthyx mentioned this pull request Feb 8, 2021
Merged
@matthyx
Copy link
Contributor

matthyx commented Feb 8, 2021

/cc @serathius
/cc @matthyx

serathius
serathius reviewed Feb 8, 2021
View reviewed changes
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
serathius
serathius reviewed Feb 8, 2021
View reviewed changes
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
serathius
serathius reviewed Feb 8, 2021
View reviewed changes
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
serathius
serathius reviewed Feb 8, 2021
View reviewed changes
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
serathius
serathius reviewed Feb 8, 2021
View reviewed changes
pkg/kubelet/container/container_gc.go Outdated Show resolved Hide resolved
pkg/kubelet/container/helpers.go Outdated Show resolved Hide resolved
pkg/kubelet/container/helpers.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2021
@yangjunmyfm192085
Copy link
Contributor Author

I have fixed all @mrunalp.

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-conformance-image-test

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-csi-serial

@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-conformance-image-test

ehashman
ehashman suggested changes Mar 17, 2021
View reviewed changes
pkg/kubelet/volumemanager/cache/actual_state_of_world.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated
@@ -142,7 +142,7 @@ func (kl *Kubelet) runPod(pod *v1.Pod, retryDelay time.Duration) error {
return fmt.Errorf("timeout error: pod %q containers not running after %d retries", format.Pod(pod), runOnceMaxRetries)
}
// TODO(proppy): health checking would be better than waiting + checking the state at the next iteration.
klog.Infof("pod %q containers synced, waiting for %v", format.Pod(pod), delay)
klog.InfoS("Pod's containers synced, waiting", "pod", klog.KObj(pod), "waitingTime", delay)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update waitingTime to duration

@yangjunmyfm192085
Structured Logging migration: modify volume and container part logs o…
01a4e4f 
…f kubelet.

Signed-off-by: JunYang <yang.jun22@zte.com.cn>
@yangjunmyfm192085
Copy link
Contributor Author

yangjunmyfm192085 commented Mar 17, 2021 •
edited
Loading

I have fixed them @ehashman

ehashman
ehashman reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 17, 2021 •
edited
Loading

@yangjunmyfm192085: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-conformance-image-test 3ec28f640bfb98267a5ad44d0023cf02af67ec8e link /test pull-kubernetes-conformance-image-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

pacoxu commented Mar 17, 2021

/retest
Need approval

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit b5c6434 into kubernetes:master Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisky adisky adisky left review comments

@serathius serathius serathius left review comments

@ehashman ehashman ehashman requested changes

@navidshaikh navidshaikh navidshaikh left review comments

@mrunalp mrunalp mrunalp approved these changes

@msau42 msau42 Awaiting requested review from msau42

@yujuhong yujuhong Awaiting requested review from yujuhong

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@sjenning sjenning

@ehashman ehashman

@serathius serathius

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
10 participants
@yangjunmyfm192085 @k8s-ci-robot @matthyx @serathius @ehashman @adisky @pacoxu @mrunalp @navidshaikh @sjenning