Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore-errors flag for drain #98203

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Add ignore-errors flag for drain #98203

merged 1 commit into from
Feb 2, 2021

Conversation

yuzhiquan
Copy link
Member

@yuzhiquan yuzhiquan commented Jan 20, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Add ignore-errors flag for drain, support none-break drain in group
Which issue(s) this PR fixes:

Fixes #97907

Special notes for your reviewer:

It's hardly to add unit test case for group drain.

Does this PR introduce a user-facing change?:

Add ignore-errors flag for drain, support none-break drain in group.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2021
@k8s-ci-robot k8s-ci-robot requested review from dixudx and seans3 January 20, 2021 07:09
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2021
@yuzhiquan
Copy link
Member Author

/assign @pwittrock
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2021
@yuzhiquan
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2021
@yuzhiquan yuzhiquan force-pushed the feature-drain-ignore-error branch from 7f66861 to cc1106f Compare January 20, 2021 10:48
@yuzhiquan yuzhiquan changed the title Add ignore-error flag for drain Add ignore-errors flag for drain Jan 20, 2021
@rikatz
Copy link
Contributor

rikatz commented Jan 20, 2021

/assign
/cc

@k8s-ci-robot k8s-ci-robot requested a review from rikatz January 20, 2021 19:40
@dougsland
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@yuzhiquan yuzhiquan force-pushed the feature-drain-ignore-error branch from b230ca2 to 7917a69 Compare January 27, 2021 01:58
@dougsland
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@yuzhiquan yuzhiquan force-pushed the feature-drain-ignore-error branch from 7917a69 to 55bd057 Compare February 1, 2021 01:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
@yuzhiquan
Copy link
Member Author

Add warning msg follow comment @dougsland
if no further review, please unhold and lgtm.

@yuzhiquan yuzhiquan force-pushed the feature-drain-ignore-error branch from 55bd057 to 69fb43b Compare February 1, 2021 02:03
@dougsland
Copy link
Member

@pwittrock needs to review and unhold.

@yuzhiquan yuzhiquan force-pushed the feature-drain-ignore-error branch from 69fb43b to db264ea Compare February 1, 2021 02:46
@yuzhiquan
Copy link
Member Author

Ping @pwittrock

@rikatz
Copy link
Contributor

rikatz commented Feb 2, 2021

/lgtm
/hold cancel

Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 2, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e26570a into kubernetes:master Feb 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 2, 2021
@github-actions github-actions bot mentioned this pull request Feb 3, 2021
Open
@yuzhiquan yuzhiquan deleted the feature-drain-ignore-error branch February 8, 2021 06:24
@coderanger
Copy link
Member

@yuzhiquan Can you please update the release notes section in the first post with more information about the deprecation? That needs to be surfaced to users.

@yuzhiquan
Copy link
Member Author

@coderanger done.

@wilsonehusin
Copy link
Contributor

hey folks, this reads like it should show up in "deprecations" section of the release notes. what do you all think? @yuzhiquan @rikatz @dougsland

@yuzhiquan
Copy link
Member Author

IMO, deprecation action not in this pr, just an warning message, this pr focus on add new flag.

@coderanger
Copy link
Member

@yuzhiquan You added fmt.Fprintf(o.ErrOut, "DEPRECATED WARNING: etc etc. That's a new deprecation unless it was previously noted somewhere else. If you would like to undo that before 1.21, I leave that to you.

@yuzhiquan
Copy link
Member Author

I see, i would remove these DEPRECATED WARNING: message, and DEPRECATED it in next release.
/cc @dougsland WDYT?

@dougsland
Copy link
Member

I see, i would remove these DEPRECATED WARNING: message, and DEPRECATED it in next release.
/cc @dougsland WDYT?

LGTM

@yuzhiquan yuzhiquan mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pandaamanda pandaamanda pandaamanda left review comments

@pwittrock pwittrock pwittrock left review comments

@dixudx dixudx dixudx left review comments

@dougsland dougsland dougsland left review comments

@seans3 seans3 Awaiting requested review from seans3

@rikatz rikatz Awaiting requested review from rikatz

Assignees

@dougsland dougsland

@rikatz rikatz

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

kubectl drain keep going when one node failed
10 participants
@yuzhiquan @rikatz @dougsland @pwittrock @k8s-ci-robot @fejta-bot @coderanger @wilsonehusin @dixudx @pandaamanda