Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate scheduler.go, factory.go to structured logging #97509

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

aldudko
Copy link
Contributor

@aldudko aldudko commented Dec 25, 2020

migrate remaining log messages in pkg/scheduler/{scheduler.go,factory.go} to structured logging.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Ref:

Does this PR introduce a user-facing change?:

NONE

Verify log output (scheduler.go):

# before
scheduler.go:338] Error updating pod foo-ns/foo: pods "foo" not found
scheduler.go:416] scheduler cache FinishBinding failed: Cannot get cache key for pod with empty UID
scheduler.go:419] Failed to bind pod: /foo
scheduler.go:462] No PostFilter plugins are registered, so no preemption will be performed.
scheduler.go:469] Status after running PostFilter plugins for pod kube-system/nginx-deployment-66b6c48dd5-sh7cn: &{2 [] <nil>}
# after
cheduler.go:338] "Error updating pod" err="pods \"foo\" not found" pod="foo-ns/foo"
scheduler.go:416] "scheduler cache FinishBinding failed" err="Cannot get cache key for pod with empty UID"
scheduler.go:419] "Failed to bind pod" pod="foo"
scheduler.go:462] "No PostFilter plugins are registered, so no preemption will be performed"
scheduler.go:469] "Status after running PostFilter plugins for pod" pod="kube-system/nginx-deployment-66b6c48dd5-kq64h" status=&{code:2 reasons:[] err:<nil>}

Verify log output (factory.go):

# before
factory.go:187] Creating scheduler from algorithm provider 'DefaultProvider'
factory.go:210] Creating scheduler from configuration: {{ } [{PodFitsResources <nil>} {PodFitsHostPorts <nil>}] [{InterPodAffinityPriority 1 <nil>}] [] 10 false}
factory.go:219] Using predicates from algorithm provider 'DefaultProvider'
factory.go:223] Registering predicate: PodFitsHostPorts
factory.go:230] Using default priorities
factory.go:238] Registering priority: InterPodAffinityPriority
factory.go:257] Creating scheduler with fit predicates 'map[CheckNodeLabelPresence:{} CheckServiceAffinity:{}]' and priority functions 'map[InterPodAffinityPriority:1 NodeAffinityPriority:2 NodeLabel:3 RequestedToCapacityRatio:2 ServiceAffinity:3]'
factory.go:323] Unable to schedule default/test-pod: possibly due to node not found: node "foo" not found; waiting
factory.go:337] "Error scheduling pod; retrying" err="binding rejected: timeout" pod="default/test-pod"
factory.go:343] Pod default/test-pod doesn't exist in informer cache: pod "test-pod" not found
factory.go:350] Pod default/test-pod has been assigned with foo. Abort adding it back to queue.
factory.go:357] pod: default/test-pod is already present in the active queue
# after
factory.go:187] "Creating scheduler from algorithm provider" algorithmProvider="DefaultProvider"
factory.go:210] "Creating scheduler from configuration" policy={TypeMeta:{Kind: APIVersion:} Predicates:[{Name:PodFitsResources Argument:<nil>} {Name:PodFitsHostPorts Argument:<nil>}] Priorities:[{Name:InterPodAffinityPriority Weight:1 Argument:<nil>}] Extenders:[] HardPodAffinitySymmetricWeight:10 AlwaysCheckAllPredicates:false}
factory.go:219] "Using predicates from algorithm provider" algorithmProvider="DefaultProvider"
factory.go:223] "Registering predicate" predicate="PodFitsHostPorts"
factory.go:230] "Using default priorities"
factory.go:238] "Registering priority" priority="InterPodAffinityPriority"
factory.go:257] "Creating scheduler" predicates=map[CheckNodeLabelPresence:{} CheckServiceAffinity:{}] priorities=map[InterPodAffinityPriority:1 NodeAffinityPriority:2 NodeLabel:3 RequestedToCapacityRatio:2 ServiceAffinity:3]
factory.go:323] "Unable to schedule pod, possibly due to node not found; waiting" pod="default/test-pod" err="node \"foo\" not found"
factory.go:337] "Error scheduling pod; retrying" err="binding rejected: timeout" pod="default/test-pod"
factory.go:343] "Pod doesn't exist in informer cache" pod="default/test-pod" err="pod \"test-pod\" not found"
factory.go:350] "Pod has been assigned to node. Abort adding it back to queue." pod="default/test-pod" node="foo"
factory.go:357] "Error occurred" err="pod: default/test-pod is already present in the active queue"

some of examples of outputted logs are missing because they are not covered by tests and are hard to reproduce in a test environment.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 25, 2020
@k8s-ci-robot
Copy link
Contributor

@aldudko: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @aldudko. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 25, 2020
@damemi
Copy link
Contributor

damemi commented Jan 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 5, 2021
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aldudko, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 172cb33 into kubernetes:master Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants