Define TestableConfig in k/apiserver/pkg/util/flowcontrol #97353
+64
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
@kubernetes/sig-api-machinery-bugs |
k8s-ci-robot
added
sig/api-machinery
|
/cc @wojtek-t |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MikeSpreitzer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Collect the parameters of newTestableController into a named type. Also tolerate the surprising situation in which a request's user groups include neither `system:authenticated` nor `system:unauthenticated` --- because this is observed to happen in some tests. Also a few other minor fixups.
MikeSpreitzer
force-pushed
the
testable-config
branch
from
cae0e27 to
10df6d4
Compare
yue9944882
reviewed
Dec 17, 2020
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
the
triage/accepted
k8s-ci-robot
removed
the
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Collect the parameters of newTestableController into a named type.
Also tolerate the surprising situation in which a request's user
groups include neither
system:authenticatednorsystem:unauthenticated--- because this is observed to happen insome tests.
Also a few other minor fixups.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This was originally part of #97036 , and was factored into a separate PR in response to review.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: