Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update help document address #96698

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Update help document address #96698

merged 1 commit into from
Jan 14, 2021

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Nov 19, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
From the issue #96697. The redirection strategy does not work properly in some browsers. It happens that the address of the document needs to be redirected. It is a good choice to modify directly to the final address

Which issue(s) this PR fixes:

Fixes #96697

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

none

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 19, 2020
@wawa0210 wawa0210 changed the title [WIP]Update help document address Update help document address Nov 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@wawa0210
Copy link
Contributor Author

/assign @smarterclayton

@k8s-ci-robot
Copy link
Contributor

@adohe: GitHub didn't allow me to assign the following users: adohe-zz.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @adohe-zz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adohe
Copy link
Contributor

adohe commented Nov 20, 2020

/assign @adohe

@wawa0210
Copy link
Contributor Author

/assign @smarterclayton

@k8s-ci-robot
Copy link
Contributor

@wawa0210: The label(s) sig/api, sig/machinery cannot be applied, because the repository doesn't have them

In response to this:

/sig api machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wawa0210
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2020
@fedebongio
Copy link
Contributor

/triage accepted
/assign @roycaihw

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 17, 2020
@dims
Copy link
Member

dims commented Jan 14, 2021

/assign @liggitt

Easy one Jordan, just fixes a broken URL

@liggitt
Copy link
Member

liggitt commented Jan 14, 2021

/lgtm
/approve

probably also worth adding a redirect to the website (https://github.com/kubernetes/website/blob/master/static/_redirects) to sweep any existing attempts to find that content

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@wawa0210
Copy link
Contributor Author

probably also worth adding a redirect to the website (https://github.com/kubernetes/website/blob/master/static/_redirects) to sweep any existing attempts to find that content

already added
https://github.com/kubernetes/website/blob/master/static/_redirects#L103

@k8s-ci-robot k8s-ci-robot merged commit c98ccce into kubernetes:master Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 14, 2021
@wawa0210 wawa0210 deleted the fix-96697 branch January 14, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@vishh vishh Awaiting requested review from vishh

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@roycaihw roycaihw

@adohe adohe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

kubectl explain redirect to a 404 page
10 participants
@wawa0210 @fejta-bot @k8s-ci-robot @adohe @fedebongio @dims @liggitt @pacoxu @smarterclayton @roycaihw