Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #92312 from Sh4d1/kep_1860" #96454

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Revert "Merge pull request #92312 from Sh4d1/kep_1860" #96454

merged 1 commit into from
Nov 13, 2020

Conversation

Sh4d1
Copy link
Member

@Sh4d1 Sh4d1 commented Nov 11, 2020 •
edited
Loading

This reverts commit ef16faf, reversing
changes made to 2343b8a.

What type of PR is this?:
/kind bug

What this PR does / why we need it:
As per kubernetes/enhancements#1860 (comment) this reverts #92312

Which issue(s) this PR fixes:

Special notes for your reviewer:
The whole PR will be reverted, I don't think the internal parts will be needed before the code freeze.

Does this PR introduce a user-facing change?:

NONE

/cc @thockin @liggitt @jeremyrickard

@Sh4d1
Revert "Merge pull request kubernetes#92312 from Sh4d1/kep_1860"
d29665c 
This reverts commit ef16faf, reversing
changes made to 2343b8a.
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider area/ipvs kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2020
@Sh4d1 Sh4d1 mentioned this pull request Nov 11, 2020
Merged
@Sh4d1
Copy link
Member Author

Sh4d1 commented Nov 11, 2020

/assign @thockin

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 11, 2020
@Sh4d1 Sh4d1 mentioned this pull request Nov 11, 2020
Open
12 tasks
@aojea
Copy link
Member

aojea commented Nov 11, 2020

/lgtm
/sig network
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@thockin
Copy link
Member

thockin commented Nov 12, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sh4d1, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 94b1788 into kubernetes:master Nov 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 13, 2020
@aojea aojea mentioned this pull request Jan 6, 2021
Closed
@mkreidenweis-schulmngr mkreidenweis-schulmngr mentioned this pull request Mar 12, 2021
Closed
@thockin
Copy link
Member

thockin commented Jul 8, 2021

@Sh4d1 Are we going to revisit this?

@thockin
Copy link
Member

thockin commented Jul 8, 2021

1.22 is locked and loaded now. 1.23 ?

@Sh4d1
Copy link
Member Author

Sh4d1 commented Aug 23, 2021

Sorry, tough summer! I also missed your review on #101027 :(

I'm going to take a break from Kubernetes starting from September, so not sure I'll be able to follow up on this one.
If someone wants to continue this:

I'll see if I can at least address the comments on the first one, but can't guarantee anything!

@chess-knight chess-knight mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

Assignees

@thockin thockin

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
5 participants
@Sh4d1 @aojea @fejta-bot @thockin @k8s-ci-robot