Remove ?namespace= param handling/defaulting #9600
Conversation
liggitt
force-pushed
the
remove_namespace_param
branch
2 times, most recently
from
6338331 to
e548616
Compare
| @@ -730,6 +695,9 @@ func (n scopeNaming) GenerateLink(req *restful.Request, obj runtime.Object) (pat | |||
| return "", "", err | |||
| } | |||
| } | |||
| if len(name) == 0 { | |||
| return "", "", errEmptyName | |||
| } | |||
There was a problem hiding this comment.
@smarterclayton can you take a look at this? rootScopeNaming#GenerateLink returned an err if Name was empty, and TestSelfLinkSkipsEmptyName was complaining unless scopeNaming#GenerateLink behaved similarly
|
LGTM |
smarterclayton
added
the
lgtm
|
@k8s-bot ok to test I guess Jenkins got stuck. Trying again for green. |
|
Hey guys, thanks for the pull request -- we sincerely appreciate the work that goes into sending us a change. As you might know, we're currently in a feature-freeze and general code slush as we work toward our 1.0 release. We're currently only accepting changes that meet any of the following criteria:
Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0. We expect the freeze to wrap up in early to mid July. If you feel that this triage is incorrect, please respond and let us know why. Thanks again for your contribution! The community is really what has made this project so exciting. |
liggitt
force-pushed
the
remove_namespace_param
branch
from
e548616 to
a341b8f
Compare
|
GCE e2e build/test passed for commit a341b8f. |
|
Part of #8087 |
| @@ -282,7 +281,7 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag | |||
| actions = appendIf(actions, action{"CONNECT", itemPath + "/{path:*}", nameParams, namer}, isConnecter && connectSubpath) | |||
|
|
|||
| } else { | |||
| // v1beta3 format with namespace in path | |||
| // v1beta3+ format with namespace in path | |||
| if scope.ParamPath() { | |||
There was a problem hiding this comment.
Why not just completely remove ParamPath()?
Remove ?namespace= param handling/defaulting
Removes obsolete handling of namespace parameter and defaulting behavior