Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure backoff step is set to 1 for Azure armclient #94180

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Ensure backoff step is set to 1 for Azure armclient #94180

merged 1 commit into from
Sep 2, 2020
+20 −3

Conversation

feiskyer
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

Ensure backoff step is set to 1 for Azure armclient. When the clients passed in a non-nil clientBackoff, the backoff steps may be 0, which would cause client panic:

kubernetes/staging/src/k8s.io/legacy-cloud-providers/azure/clients/armclient/azure_armclient.go

Lines 65 to 71 in 14a1106

backoff := clientBackoff
if backoff == nil {
// 1 steps means no retry.
backoff = &retry.Backoff{
Steps: 1,
}
}

This PR fixes the issue by ensuring the backoff step is 1 on such case.

Which issue(s) this PR fixes:

Refer #94078 (comment).

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Ensure backoff step is set to 1 for Azure armclient.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 23, 2020
@feiskyer feiskyer mentioned this pull request Aug 23, 2020
Merged
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 23, 2020
@feiskyer
Copy link
Member Author

/priority important-soon
/kind bug
/sig cloud-provider
/area provider/azure

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/provider/azure Issues or PRs related to azure provider and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 23, 2020
@feiskyer
Copy link
Member Author

/assign @nilo19

@bpineau
Copy link
Contributor

bpineau commented Aug 23, 2020

Awesome, thanks for the fix @feiskyer !

@nilo19
Copy link
Member

nilo19 commented Aug 23, 2020

/retest

2 similar comments
@feiskyer
Copy link
Member Author

/retest

@nilo19
Copy link
Member

nilo19 commented Aug 24, 2020

/retest

@feiskyer
Copy link
Member Author

feiskyer commented Sep 2, 2020

/retest
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 2, 2020
@nilo19
Copy link
Member

nilo19 commented Sep 2, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 54f3b85 into kubernetes:master Sep 2, 2020
@feiskyer feiskyer deleted the fix-backoff branch September 7, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@feiskyer @k8s-ci-robot @bpineau @nilo19