Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bgrant0607 to emeritus status. #93665

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Move bgrant0607 to emeritus status. #93665

merged 1 commit into from
Aug 14, 2020

Conversation

dims
Copy link
Member

@dims dims commented Aug 4, 2020

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Per note in #93637 (comment) @bgrant0607 has requested to be marked as emeritus.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
@bgrant0607 - Thank you for all your work over the years! Should you find the time again to dive into things, we'll be so happy to move you back.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig contributor-experience
/priority important-soon

/assign @bgrant0607

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 4, 2020
@dims dims changed the title Move bgrant0607 to emeritus status. [WIP] Move bgrant0607 to emeritus status. Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2020
@bgrant0607 bgrant0607 changed the title [WIP] Move bgrant0607 to emeritus status. Move bgrant0607 to emeritus status. Aug 4, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2020
@dims
Move bgrant0607 to emeritus status.
fbca4e3 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the emeritus-bgrant0607 branch from c35d186 to fbca4e3 Compare August 4, 2020 01:50
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2020
@bgrant0607
Copy link
Member

Thanks, @dims. I'm happy to move to emeritus, at least for now, since I can't respond in a timely fashion to review/approval requests.

I wonder if this will let me approve since I won't be in the future approval list. :-)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 4, 2020
@dims
Copy link
Member Author

dims commented Aug 4, 2020

/assign @thockin @liggitt

@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Aug 4, 2020
@BenTheElder
Copy link
Member

@bgrant0607 thank you 🙃

I wonder if this will let me approve since I won't be in the future approval list. :-)

For the record / for anyone curious: approval is always computed from the OWNERS files in the target branch (master here).

@spiffxp
Copy link
Member

spiffxp commented Aug 4, 2020

/retest

@dims
Copy link
Member Author

dims commented Aug 13, 2020

/test pull-kubernetes-e2e-kind-ipv6
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 13, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member

liggitt commented Aug 14, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit fa1a3e0 into kubernetes:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@liggitt liggitt

@thockin thockin

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@dims @bgrant0607 @k8s-ci-robot @BenTheElder @spiffxp @fejta-bot @liggitt @thockin