Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] Update Golang to v1.13.14 #93235

Merged
merged 6 commits into from
Jul 20, 2020
Merged

[1.16] Update Golang to v1.13.14 #93235

merged 6 commits into from
Jul 20, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 19, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup
/area dependency release-eng
/sig testing release

What this PR does / why we need it:

Update Golang to v1.13.14.

Tracking issue: kubernetes/release#1410

Which issue(s) this PR fixes:

Special notes for your reviewer:

Includes the bazel updates from #93219.
If this goes green without issue, I'll close the previous PR and update the release note here instead.

Combined cherry pick of #89430, #90347, #91312, bddd520, and #92362.

Does this PR introduce a user-facing change?:

- Update Golang to v1.13.14
- Update bazel to 2.2.0
- Update repo-infra to 0.0.8 (to support go1.14.6 and go1.13.14)
  - Includes:
    - bazelbuild/bazel-toolchains@3.4.0
    - bazelbuild/rules_go@v0.22.8

mikedanese and others added 6 commits July 19, 2020 00:46
@mikedanese @justaugustus
Update bazel to 2.2.0
7cb68bd
@fejta @justaugustus
Update to repo-infra v0.0.4
d8472a4 
And use repo-infra to configure rules_go and rbe
@justaugustus
build: Update to repo-infra@v0.0.5 to support go1.14.3 and go1.13.11
b6e7775 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Update repo-infra to v0.0.8 (to support go1.14.6 and go1.13.14)
abff8af 
Includes:
- bazelbuild/bazel-toolchains@3.4.0
- bazelbuild/rules_go@v0.22.8

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@brianpursley @justaugustus
Add bazel_skylib_workspace to fix make bazel-test 'no matching toolch…
1d48243 
…ains found' error
@justaugustus
Update Golang to v1.13.14
643578c 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 19, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Jul 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from deads2k and ixdy July 19, 2020 20:17
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 19, 2020
@mkumatag mkumatag mentioned this pull request Jul 19, 2020
Closed
18 tasks
@justaugustus justaugustus mentioned this pull request Jul 19, 2020
Merged
@justaugustus
Copy link
Member Author

pull-kubernetes-e2e-gce-device-plugin-gpu is a known flake.
/skip

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 19, 2020 •
edited
Loading

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 643578c link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

@justaugustus justaugustus mentioned this pull request Jul 19, 2020
Closed
@justaugustus
Copy link
Member Author

Ready for review.
/assign @liggitt @dims @BenTheElder
cc: @kubernetes/release-engineering

@justaugustus justaugustus mentioned this pull request Jul 20, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Jul 20, 2020

/cc @mikedanese @fejta
can you ack the bazel changes?

@k8s-ci-robot k8s-ci-robot requested review from fejta and mikedanese July 20, 2020 13:56
liggitt
liggitt reviewed Jul 20, 2020
View reviewed changes
build/root/.bazelrc
build:cross:linux_arm64 --config=repo_infra_crosstool --platforms=@io_bazel_rules_go//go/toolchain:linux_arm64 --cpu=arm64
build:cross:linux_ppc64le --config=repo_infra_crosstool --platforms=@io_bazel_rules_go//go/toolchain:linux_ppc64le --cpu=ppc64le
build:cross:linux_s390x --config=repo_infra_crosstool --platforms=@io_bazel_rules_go//go/toolchain:linux_s390x --cpu=s390x
# These cross-compilation targets are most likely non-functional.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cross-compilation targets are most likely non-functional.

that's ominous...

@liggitt
Copy link
Member

liggitt commented Jul 20, 2020

verified this matches master bazel bits, and CI passes

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
hasheddan
hasheddan approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 46579bd into kubernetes:release-1.16 Jul 20, 2020
@fejta
Copy link
Contributor

fejta commented Jul 20, 2020

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@hasheddan hasheddan hasheddan approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@ixdy ixdy Awaiting requested review from ixdy

@fejta fejta Awaiting requested review from fejta

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@dims dims

@BenTheElder BenTheElder

@liggitt liggitt

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
9 participants
@justaugustus @k8s-ci-robot @liggitt @fejta @hasheddan @dims @BenTheElder @mikedanese @brianpursley