Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto triage sig-instrumentation tagged PRs #93160

Merged
merged 1 commit into from
Jul 23, 2020
Merged

auto triage sig-instrumentation tagged PRs #93160

merged 1 commit into from
Jul 23, 2020

Conversation

logicalhan
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR leverages our automated labeling mechanism to tag sig-instrumentation PRs with triage labels. This builds off of #90220 and extends it in a similar way to #93156

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig instrumentation

auto triage sig-instrumentation tagged PRs
f3c02d7 
Change-Id: Ibae7373fb197485aeb222f1455515178cc3b4d13
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 16, 2020
@k8s-ci-robot
Copy link
Contributor

@logicalhan: The label(s) sig/ cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR leverages our automated labeling mechanism to tag sig-instrumentation PRs with triage labels. This builds off of #90220 and extends it in a similar way to #93156

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig instrumentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 16, 2020
@logicalhan
Copy link
Member Author

/assign @ehashman @brancz @dashpole

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 16, 2020
@dashpole
Copy link
Contributor

/lgtm
/approve

@dashpole
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2020
@ehashman
Copy link
Member

I'm on vacation, don't assign me things @logicalhan ;)

@logicalhan
Copy link
Member Author

I'm on vacation, don't assign me things @logicalhan ;)

Ah sorry! why are you checking your email though? :D

@logicalhan
Copy link
Member Author

/retest

@logicalhan
Copy link
Member Author

/retest

@lavalamp
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, lavalamp, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@logicalhan
Copy link
Member Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@RainbowMango
Copy link
Member

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1ed2cf1 into kubernetes:master Jul 23, 2020
nikhita added a commit to nikhita/kubernetes that referenced this pull request Jul 24, 2020
@nikhita
Revert "Merge pull request kubernetes#93160 from logicalhan/triage-in…
3a74f46 
…strumentation"

This reverts commit 1ed2cf1, reversing
changes made to 04ecdb9.
@nikhita nikhita mentioned this pull request Jul 24, 2020
Merged
sharadg pushed a commit to sharadg/kubernetes that referenced this pull request Oct 23, 2020
@nikhita @sharadg
Revert "Merge pull request kubernetes#93160 from logicalhan/triage-in…
18664b3 
…strumentation"

This reverts commit 1ed2cf1, reversing
changes made to 04ecdb9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@dashpole dashpole

@brancz brancz

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@logicalhan @k8s-ci-robot @dashpole @ehashman @lavalamp @fejta-bot @RainbowMango @brancz