Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically assign triage labels to api-machinery tagged PRs #93156

Merged
merged 1 commit into from
Jul 22, 2020
Merged

automatically assign triage labels to api-machinery tagged PRs #93156

merged 1 commit into from
Jul 22, 2020

Conversation

logicalhan
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This adds auto-triage labeling to sig api-machinery related code changes.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/assign @fedebongio

automatically assign triage labels to api-machinery tagged PRs
9129dbc 
Change-Id: Ifcc8a85d190d6370423af27f6e6c4c90b8472981
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2020
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 16, 2020
@lavalamp
Copy link
Member

/approve

(someone who knows how this works should LGTM ;) )

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@logicalhan logicalhan mentioned this pull request Jul 16, 2020
Merged
@logicalhan
Copy link
Member Author

/retest

@fedebongio
Copy link
Contributor

/lgtm
thank you @logicalhan

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@logicalhan
Copy link
Member Author

/retest

@ahg-g
Copy link
Member

ahg-g commented Jul 21, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 32438cf into kubernetes:master Jul 22, 2020
nikhita added a commit to nikhita/kubernetes that referenced this pull request Jul 24, 2020
@nikhita
Revert "Merge pull request kubernetes#93156 from logicalhan/triage-ap…
c00dae0 
…i-machinery"

This reverts commit 32438cf, reversing
changes made to bb6a6aa.
@nikhita nikhita mentioned this pull request Jul 24, 2020
Merged
sharadg pushed a commit to sharadg/kubernetes that referenced this pull request Oct 23, 2020
@nikhita @sharadg
Revert "Merge pull request kubernetes#93156 from logicalhan/triage-ap…
6fceb91 
…i-machinery"

This reverts commit 32438cf, reversing
changes made to bb6a6aa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@vishh vishh Awaiting requested review from vishh

Assignees

@fedebongio fedebongio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@logicalhan @lavalamp @k8s-ci-robot @fedebongio @fejta-bot @ahg-g