Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extending DSR loadbalancer feature in winkernel kube-proxy to HNS versions 9.3-9.max, 10.2+ #93080

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Extending DSR loadbalancer feature in winkernel kube-proxy to HNS versions 9.3-9.max, 10.2+ #93080

merged 1 commit into from
Jul 22, 2020

Conversation

elweb9858
Copy link
Contributor

@elweb9858 elweb9858 commented Jul 14, 2020 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR introduces an updated version of hcsshim, which has the latest version check for DSR loadbalancers, which are used in winkernel kube-proxy. Customers running on older versions of Windows (HNS versions 9.3-9.max, 10.2+) will be able to use the DSR feature with these changes.

Which issue(s) this PR fixes:

Fixes #93304

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Extended DSR loadbalancer feature in winkernel kube-proxy to HNS versions 9.3-9.max, 10.2+

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @elweb9858. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2020
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2020
@elweb9858
Copy link
Contributor Author

/assign @madhanrm

@elweb9858
Copy link
Contributor Author

/assign @ksubrmnn

@elweb9858
Copy link
Contributor Author

/assign @kumarvin123

@elweb9858
Copy link
Contributor Author

/assign @sbangari

@k8s-ci-robot
Copy link
Contributor

@elweb9858: GitHub didn't allow me to assign the following users: sbangari.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sbangari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elweb9858
Copy link
Contributor Author

fyi @Keith-Mange @sbangari

@madhanrm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2020
@elweb9858
Copy link
Contributor Author

/retest

@elweb9858
Copy link
Contributor Author

fyi @daschott

@elweb9858
Copy link
Contributor Author

@feiskyer I know it's a bit late in the cycle, but we are trying to get this in v1.19. Any chance you could mark this PR with the v1.19 milestone?

@elweb9858
Copy link
Contributor Author

/retest

@daschott
Copy link
Contributor

/cc @michmike

@k8s-ci-robot k8s-ci-robot requested a review from michmike July 15, 2020 01:26
@daschott daschott mentioned this pull request Jul 16, 2020
Closed
@elweb9858
Copy link
Contributor Author

/retest

@ksubrmnn
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2020
@elweb9858
Copy link
Contributor Author

/retest

@elweb9858 elweb9858 mentioned this pull request Jul 16, 2020
Closed
@dims
Copy link
Member

dims commented Jul 16, 2020 •
edited
Loading

/assign @liggitt @smarterclayton

Sorry i don't have root approval privs :(

@liggitt
Copy link
Member

liggitt commented Jul 16, 2020 •
edited
Loading

/approve
for dependency mechanics

/hold
would like a clean CI run once #93063 #93263 merges, then can unhold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elweb9858, ksubrmnn, liggitt, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@liggitt
Copy link
Member

liggitt commented Jul 18, 2020 •
edited
Loading

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/93080/pull-kubernetes-node-e2e/1283460130247020544 and https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/93080/pull-kubernetes-node-e2e/1283166013302509568 flakes are #93210

@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

@elweb9858 can you add a link to the bug this is fixing?

@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

@michmike can cancel the hold on this once the two azure jobs pass

@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

opened #93295 for CI failure

@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

azure jobs are green

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@elweb9858
Copy link
Contributor Author

/retest

@daschott
Copy link
Contributor

@liggitt here is the bug this is fixing: #93304

There are many other bugs that need the DSR mode to be properly resolved, such as Azure/AKS#1375

@michmike
Copy link
Contributor

/retest

3 similar comments
@elweb9858
Copy link
Contributor Author

/retest

@elweb9858
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Jul 22, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7ace19b into kubernetes:master Jul 22, 2020
@github-actions github-actions bot mentioned this pull request Jul 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksubrmnn ksubrmnn ksubrmnn approved these changes

@liggitt liggitt liggitt left review comments

@kumarvin123 kumarvin123 kumarvin123 approved these changes

@JocelynBerrendonner JocelynBerrendonner JocelynBerrendonner approved these changes

@michmike michmike michmike approved these changes

@dineshgovindasamy dineshgovindasamy Awaiting requested review from dineshgovindasamy

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@michmike michmike

@madhanrm madhanrm

@ksubrmnn ksubrmnn

@kumarvin123 kumarvin123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Windows HNS version check for DSR feature is failing on RS5, even though it is supported