-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSONPath template language #9296
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
||
import ( | ||
"errors" | ||
"github.com/GoogleCloudPlatform/kubernetes/third_party/golang/parse" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please separate out the non std library imports and put them below in a separate section. (see other files for examples of this)
(also, this dependency should be managed with godeps)
@brendandburns Thanks for reviewing my code. I correct all mistakes except for the third_party code problem. Actually, for the third_party code, I write 30% of them and the rest are copied from golang project. |
I rewrite parser so the parser code do't need to be put in third party directory. |
This is failing Shippable, I think we need to rebase the gsoc branch to HEAD (and in general, Shippable doesn't seem to handle testing PRs to branches other than master very well) |
@daizuozhuo Please ping any open PRs and/or issues with current status at least once a week to ensure they don't drop off our radar. |
@brendandburns I have finished all features. Could you review it? |
yes, will look by the end of the week. Thanks! |
@brendandburns I just added doc.go. Can you take a look at it? |
Thanks. More examples: Getting info about last termination(s):
Getting external IP of a service of type LoadBalancer, which I found easier to do with grep than with a template:
|
While awaiting another review on this, you could write another PR that adds this as a new output format to kubectl, such as |
I would like to eventually use this to specify field references in the downward API. |
case *IdentifierNode: | ||
return j.evalIdentifier(value, node) | ||
default: | ||
return value, fmt.Errorf("unexpect Node %v", node) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"unexpected Node %v"
Few small comments and a request for parser tests for ill-formed input. |
@bgrant0607 To get external IP of a service of type LoadBalancer, we can use |
Ok, since we're now in post 1.0, can you rebase this on master, and we can merge it in. Thanks! |
@brendandburns Do you mean reopen this pull request on master? If not, can you tell me how to do this? |
@brendandburns Thanks. Here are features in this pull request: