Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cAdvisor to v0.37.0 #92919

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Update cAdvisor to v0.37.0 #92919

merged 1 commit into from
Jul 12, 2020

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jul 8, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
cAdvisor does a release for each kubernetes release. This is the release for k8s 1.19. It has a number of bug-fixes and improvements.

Because we switched to a different cAdvisor interface for serving prometheus metrics, I had to change a bunch of interfaces in the kubelet. But the behavior is exactly the same.

Does this PR introduce a user-facing change?:

Fix detection of image filesystem, disk metrics for devicemapper, detection of OOM Kills on 5.0+ linux kernels.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl labels Jul 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from andyzhangx, cheftako and a team July 8, 2020 21:05
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 8, 2020
@dashpole
Copy link
Contributor Author

dashpole commented Jul 8, 2020

/assign @dchen1107

@dashpole
Copy link
Contributor Author

dashpole commented Jul 8, 2020

/retest

@dashpole
Copy link
Contributor Author

dashpole commented Jul 8, 2020

/retest

1 similar comment
@dashpole
Copy link
Contributor Author

dashpole commented Jul 8, 2020

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020
@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/assign @smarterclayton @liggitt

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

2 similar comments
@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

3 similar comments
@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/assign @thockin

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jul 9, 2020

/lgtm
/approve

@liggitt liggitt added this to the v1.19 milestone Jul 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

can I get 1.19 milestone as well?

@dashpole
Copy link
Contributor Author

dashpole commented Jul 9, 2020

/retest

@dashpole
Copy link
Contributor Author

/milestone 1.19

@k8s-ci-robot
Copy link
Contributor

@dashpole: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Contributor Author

@dims can you help with the milestone?

@liggitt
Copy link
Member

liggitt commented Jul 10, 2020

This is already in the milestone

@dims
Copy link
Member

dims commented Jul 10, 2020

cross my fingers 🤞 !!

@dashpole
Copy link
Contributor Author

ah, my bad

@k8s-ci-robot k8s-ci-robot merged commit 6b5dc37 into kubernetes:master Jul 12, 2020
@github-actions github-actions bot mentioned this pull request Jul 14, 2020
Open
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@thockin thockin

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@dashpole @dchen1107 @liggitt @k8s-ci-robot @dims @cheftako @smarterclayton @thockin