Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] hyperkube: Use debian-hyperkube-base@v1.1.0 image #92495

Merged
merged 1 commit into from
Jun 25, 2020
Merged

[1.16] hyperkube: Use debian-hyperkube-base@v1.1.0 image #92495

merged 1 commit into from
Jun 25, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jun 24, 2020 •
edited
Loading

What type of PR is this?

/kind regression
/priority critical-urgent

What this PR does / why we need it:

Use debian-hyperkube-base@v1.1.0 image built in #92354.

Signed-off-by: Stephen Augustus saugustus@vmware.com

cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Attempt to fix the following issues: #92275, #92272, #92250.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- hyperkube: Use debian-hyperkube-base@v1.1.0 image

  A previous release built hyperkube using the debian-hyperkube-base@v1.0.0,
  which was updated to address a CVE in the CNI plugins.
  
  A side-effect of using this new image was that the networking packages
  (namely `iptables`) drifted from the versions used in the kube-proxy images.

  The following issues were filed on kube-proxy failures when using hyperkube:
  - https://github.com/kubernetes/kubernetes/issues/92275
  - https://github.com/kubernetes/kubernetes/issues/92272
  - https://github.com/kubernetes/kubernetes/issues/92250

  To address this, the new debian-hyperkube-base image (v1.1.0) uses the
  debian-iptables base image (v12.1.0), which includes iptables-wrapper, a
  script used to determine the correct iptables mode to run in.

@justaugustus
hyperkube: Use debian-hyperkube-base@v1.1.0 image
5b5631b 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 24, 2020
@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from ixdy and lavalamp June 24, 2020 22:58
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2020
@justaugustus
Copy link
Member Author

/assign @BenTheElder @ixdy @mikedanese

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@justaugustus
Copy link
Member Author

/test pull-kubernetes-verify

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 25, 2020
@justaugustus
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@cpanato
Copy link
Member

cpanato commented Jun 25, 2020

/test pull-kubernetes-verify

cpanato
cpanato approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
saschagrunert
saschagrunert approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liggitt
Copy link
Member

liggitt commented Jun 25, 2020

/lgtm
/approve

I know our hyperkube testing story is difficult, let's make sure this is verified/tested on the systems that reported iptables problems before official release

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
hasheddan
hasheddan approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 66613b3 into kubernetes:release-1.16 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@ixdy ixdy Awaiting requested review from ixdy

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@saschagrunert saschagrunert

@BenTheElder BenTheElder

@liggitt liggitt

@mikedanese mikedanese

@cpanato cpanato

@ixdy ixdy

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
9 participants
@justaugustus @cpanato @liggitt @k8s-ci-robot @saschagrunert @hasheddan @BenTheElder @mikedanese @ixdy