Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade apiserver-network-proxy to v0.0.9 #91922

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Upgrade apiserver-network-proxy to v0.0.9 #91922

merged 2 commits into from
Jun 17, 2020

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Jun 8, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

Upgrade network proxy to v0.0.9. Includes fixes for UDS socket leak and adds a health port.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 8, 2020
@Jefftree
Copy link
Member Author

Jefftree commented Jun 8, 2020

/test pull-kubernetes-e2e-gce-network-proxy-grpc
/test pull-kubernetes-e2e-gce-network-proxy-http-connect

@k8s-ci-robot k8s-ci-robot requested review from cheftako, deads2k and a team June 8, 2020 23:16
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 8, 2020
@Jefftree
Copy link
Member Author

Jefftree commented Jun 9, 2020

/retest

@Jefftree
Copy link
Member Author

Jefftree commented Jun 9, 2020

Waiting for kubernetes/k8s.io#945 to pass CI.

@Jefftree
Copy link
Member Author

/retest

1 similar comment
@Jefftree
Copy link
Member Author

/retest

@Jefftree
Copy link
Member Author

/assign @cheftako
/assign @caesarxuchao

@cheftako
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@Jefftree
Copy link
Member Author

/assign @liggitt (for deps approval)
/retest

@cheftako
Copy link
Member

/test pull-kubernetes-kubemark-e2e-gce-big

@cheftako
Copy link
Member

/lgtm

@liggitt
Copy link
Member

liggitt commented Jun 16, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 51aac92 into kubernetes:master Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 17, 2020
@Jefftree Jefftree deleted the netproxy-009 branch December 7, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@cheftako cheftako

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@Jefftree @cheftako @liggitt @k8s-ci-robot @caesarxuchao