Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing refcounting of remote endpoints used across services #91706

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Fixing refcounting of remote endpoints used across services #91706

merged 1 commit into from
Jun 9, 2020

Conversation

sbangari
Copy link
Contributor

@sbangari sbangari commented Jun 3, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
In kube-proxy a ref count is maintained on the remote endpoints created for a service. The remote endpoints are deleted from HNS when they are no longer in use by kube-proxy (i.e. refcount is dropped to zero). In the current logic the refcount on the remote endpoints is scoped to a service. So when the service is deleted all the remote endpoints referred by it are no longer in use and they are cleaned up dropping the refcount to 0. This deletes the remote endpoints in HNS. When a remote endpoint is shared across two services this causes a problem since the second service is still referring to it, but the backing HNS remote endpoint is deleted and no longer available.

Fix: A global refcount is maintained for all the remote endpoints created across services. The backing HNS remote endpoint is only deleted when it is no longer in use by any service.

Which issue(s) this PR fixes:

Fixes #91703

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sbangari. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbangari
Copy link
Contributor Author

sbangari commented Jun 3, 2020

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@sbangari: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 3, 2020
@madhanrm
Copy link
Contributor

madhanrm commented Jun 3, 2020

/sig windows
/ok-to-test

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2020
@sbangari
Copy link
Contributor Author

sbangari commented Jun 3, 2020

/retest

1 similar comment
@sbangari
Copy link
Contributor Author

sbangari commented Jun 3, 2020

/retest

@sbangari sbangari force-pushed the remoteendpointrefcount branch from fc3b383 to 0760c04 Compare June 3, 2020 22:37
@sbangari
Copy link
Contributor Author

sbangari commented Jun 3, 2020

/retest

1 similar comment
@sbangari
Copy link
Contributor Author

sbangari commented Jun 4, 2020

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2020
@sbangari sbangari force-pushed the remoteendpointrefcount branch from 0760c04 to cd43fc9 Compare June 5, 2020 05:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2020
@sbangari
Copy link
Contributor Author

sbangari commented Jun 8, 2020

/retest

@madhanrm
Copy link
Contributor

madhanrm commented Jun 8, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: madhanrm, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@JocelynBerrendonner
Copy link

LGTM

elweb9858
elweb9858 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@elweb9858 elweb9858 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kumarvin123
Copy link
Contributor

/LGTM

@k8s-ci-robot
Copy link
Contributor

@kumarvin123: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 86e1415 into kubernetes:master Jun 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 9, 2020
Keith-Mange
Keith-Mange reviewed Jun 9, 2020
View reviewed changes
Copy link

@Keith-Mange Keith-Mange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Jun 19, 2020
Closed
Closed
@ksubrmnn ksubrmnn mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-Mange Keith-Mange Keith-Mange left review comments

@elweb9858 elweb9858 elweb9858 approved these changes

@kumarvin123 kumarvin123 kumarvin123 approved these changes

@dineshgovindasamy dineshgovindasamy Awaiting requested review from dineshgovindasamy

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@madhanrm madhanrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Windows Kubeproxy causes data path issues when multiple services refer the same endpoints
7 participants
@sbangari @k8s-ci-robot @madhanrm @JocelynBerrendonner @kumarvin123 @elweb9858 @Keith-Mange