Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cri-tools to v1.18.0 (#2) #91564

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Update cri-tools to v1.18.0 (#2) #91564

merged 1 commit into from
Jun 1, 2020
+23 −21

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
This updates cri-tools to the latest release as well as pointing the
artifacts to the new Google Cloud Bucket k8s-artifacts-cri-tools.

Which issue(s) this PR fixes:

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 29, 2020
@saschagrunert saschagrunert changed the title Update cri-tools to v1.18.0 Update cri-tools to v1.18.0 (#2) May 29, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 29, 2020
@k8s-ci-robot k8s-ci-robot requested review from lavalamp and roycaihw May 29, 2020 07:15
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Update cri-tools to v1.18.0
d2fc2d2 
This updates cri-tools to the latest release as well as pointing the
artifacts to the new Google Cloud Bucket `k8s-artifacts-cri-tools`.

This reverts commit ce1840d.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

Please take a look @kubernetes/release-managers

@saschagrunert
Copy link
Member Author

cc @kubernetes/release-engineering

@justaugustus
Copy link
Member

/sig node release
/area release-eng

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 29, 2020
@justaugustus
Copy link
Member

For RelEng:
/lgtm
/approve

Assigning original approvers:
/assign @feiskyer @fejta @BenTheElder

FYI for scale:
/cc @mm4tt @wojtek-t

@k8s-ci-robot k8s-ci-robot requested review from mm4tt and wojtek-t May 29, 2020 18:58
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@justaugustus justaugustus mentioned this pull request May 30, 2020
Closed
11 tasks
feiskyer
feiskyer reviewed May 30, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@BenTheElder
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, feiskyer, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind d2fc2d2 link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit c544449 into kubernetes:master Jun 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 1, 2020
@saschagrunert saschagrunert deleted the update-cri-tools branch June 2, 2020 06:30
This was referenced Jun 2, 2020
Closed
Closed
Closed
@pjh
Copy link
Contributor

pjh commented Jun 4, 2020 •
edited
Loading

It looks like this PR had a bug in the powershell script change - Windows clusters are failing to come up in our tests at https://testgrid.k8s.io/google-windows#gce-windows-2019-master&width=20. Looking at the serial port output for one of the Windows nodes in the test artifacts, I see:

2020/06/03 12:18:23 GCEMetadataScripts: windows-startup-script-ps1: Failed to download file from https://storage.googleapis.com/$CRI_TOOLS_GCS_BUCKET/release/v1.18.0/crictl-v1.18.0-windows-amd64.tar.gz. Will retry. Error: System.Net.WebException: The remote server returned an error: (400) Bad Request.

Not a huge deal, we can try to fix-forward tomorrow.

@pjh pjh mentioned this pull request Jun 4, 2020
Closed
@saschagrunert
Copy link
Member Author

It looks like this PR had a bug in the powershell script change - Windows clusters are failing to come up in our tests at https://testgrid.k8s.io/google-windows#gce-windows-2019-master&width=20. Looking at the serial port output for one of the Windows nodes in the test artifacts, I see:

2020/06/03 12:18:23 GCEMetadataScripts: windows-startup-script-ps1: Failed to download file from https://storage.googleapis.com/$CRI_TOOLS_GCS_BUCKET/release/v1.18.0/crictl-v1.18.0-windows-amd64.tar.gz. Will retry. Error: System.Net.WebException: The remote server returned an error: (400) Bad Request.

Not a huge deal, we can try to fix-forward tomorrow.

Ah thank you for the hint. Unfortunately I cannot test the powershell scripts on my Linux machine. Can I run the windows tests on a per PR basis via a /test trigger? Maybe this way I can try to fix it.

@pjh
Copy link
Contributor

pjh commented Jun 4, 2020

Yeah, we have /test pull-kubernetes-e2e-windows-gce to bring up a cluster with Windows nodes on GCE and run some tests. It's somewhat flaky so we haven't made it run automatically anywhere yet, and I'm not sure it's documented anywhere.

@pjh pjh mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@roycaihw roycaihw Awaiting requested review from roycaihw

@mm4tt mm4tt Awaiting requested review from mm4tt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@justaugustus justaugustus

@feiskyer feiskyer

@BenTheElder BenTheElder

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@saschagrunert @justaugustus @BenTheElder @k8s-ci-robot @pjh @feiskyer @fejta