Change isVolumeConflict so read-only gce persistent disks don't confl… #9056
Conversation
…ict with each other
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
| @@ -52,12 +52,13 @@ func (nodes ClientNodeInfo) GetNodeInfo(nodeID string) (*api.Node, error) { | |||
|
|
|||
| func isVolumeConflict(volume api.Volume, pod *api.Pod) bool { | |||
There was a problem hiding this comment.
Medium-to-long term, anything related to specific volume implementations should move to pkg/volume and be part of the plugin interface.
|
ok to test |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build failed. |
|
I don't really understand the error I'm seeing here, is this something I can fix? |
|
Don't worry about EXPERIMENTAL JENKINS PR BUILDER. He's experimental. On Mon, Jun 1, 2015 at 12:25 PM, runningwild notifications@github.com
|
davidopp
added
the
lgtm
|
LGTM I think this is OK to merge because in some sense it was a bug (or at least a usability issue). (Otherwise we are under code freeze.) |
Change isVolumeConflict so read-only gce persistent disks don't confl…
…ict with each other
Fixes issue #8478.
This doesn't address the problem of two pods on different machines trying to mount the same disk in read-write mode, but I assume that is not within the scope of this issue.