Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy metrics client from podautoscaler #90368

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Remove legacy metrics client from podautoscaler #90368

merged 1 commit into from
Jun 5, 2021

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Apr 22, 2020 •
edited by liggitt
Loading

/kind cleanup

kube-controller-manger: the `--horizontal-pod-autoscaler-use-rest-clients`  flag and Heapster support in the horizontal pod autoscaler, deprecated since 1.12, is removed.

/sig instrumentation
/sig autoscaling
/priority important-longterm
/assign @MaciekPytel

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 22, 2020
@k8s-ci-robot k8s-ci-robot requested review from eparis and jsafrane April 22, 2020 18:11
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 22, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

logicalhan
logicalhan reviewed Apr 23, 2020
View reviewed changes
cmd/kube-controller-manager/app/options/hpacontroller.go
@@ -40,9 +40,7 @@ func (o *HPAControllerOptions) AddFlags(fs *pflag.FlagSet) {
fs.DurationVar(&o.HorizontalPodAutoscalerDownscaleForbiddenWindow.Duration, "horizontal-pod-autoscaler-downscale-delay", o.HorizontalPodAutoscalerDownscaleForbiddenWindow.Duration, "The period since last downscale, before another downscale can be performed in horizontal pod autoscaler.")
fs.MarkDeprecated("horizontal-pod-autoscaler-downscale-delay", "This flag is currently no-op and will be deleted.")
fs.Float64Var(&o.HorizontalPodAutoscalerTolerance, "horizontal-pod-autoscaler-tolerance", o.HorizontalPodAutoscalerTolerance, "The minimum change (from 1.0) in the desired-to-actual metrics ratio for the horizontal pod autoscaler to consider scaling.")
fs.BoolVar(&o.HorizontalPodAutoscalerUseRESTClients, "horizontal-pod-autoscaler-use-rest-clients", o.HorizontalPodAutoscalerUseRESTClients, "If set to true, causes the horizontal pod autoscaler controller to use REST clients through the kube-aggregator, instead of using the legacy metrics client through the API server proxy. This is required for custom metrics support in the horizontal pod autoscaler.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe to remove? How long has this flag been deprecated? (https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-flag-or-cli)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#68089
1.12

@logicalhan
Copy link
Member

I think you need to run hack/update-bazel.sh and possibly hack/update-vendor.sh

@fedebongio
Copy link
Contributor

/assign @logicalhan

@serathius serathius force-pushed the remove-legacy-metrics branch from ebc1927 to 7f2791e Compare April 24, 2020 14:42
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2020
@serathius
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2020
@serathius
Copy link
Contributor Author

/assign @lavalamp

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021
@serathius serathius force-pushed the remove-legacy-metrics branch from b23e3c6 to dc066bb Compare May 29, 2021 20:09
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2021
@serathius serathius force-pushed the remove-legacy-metrics branch from dc066bb to ac9de7e Compare May 29, 2021 20:45
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label May 29, 2021
@serathius serathius force-pushed the remove-legacy-metrics branch 3 times, most recently from 51144dc to b30094c Compare June 4, 2021 12:32
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2021 •
edited
Loading

@serathius: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 7f2791ef5114a7c9b9d5e793408233d1e86936c0 link /test pull-kubernetes-e2e-gce
pull-kubernetes-kubemark-e2e-gce-big 7f2791ef5114a7c9b9d5e793408233d1e86936c0 link /test pull-kubernetes-kubemark-e2e-gce-big

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@serathius serathius force-pushed the remove-legacy-metrics branch from b30094c to f20f488 Compare June 4, 2021 19:19
@serathius
Copy link
Contributor Author

ping @lavalamp
/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt June 4, 2021 20:13
@liggitt
Copy link
Member

liggitt commented Jun 4, 2021

drop the lines in cluster/gce/gci/configure-helper.sh that set --horizontal-pod-autoscaler-use-rest-clients

lgtm otherwise

@serathius serathius force-pushed the remove-legacy-metrics branch from f20f488 to 4ebc0c9 Compare June 4, 2021 21:06
@serathius
Copy link
Contributor Author

Done

@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jun 4, 2021
@liggitt
Copy link
Member

liggitt commented Jun 4, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit e6a8bc9 into kubernetes:master Jun 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 5, 2021
@binacs binacs mentioned this pull request Jun 6, 2021
Closed
@ialidzhikov ialidzhikov mentioned this pull request Mar 5, 2022
Merged
@SataQiu SataQiu mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan left review comments

@eparis eparis Awaiting requested review from eparis

@jsafrane jsafrane Awaiting requested review from jsafrane

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@lavalamp lavalamp

@logicalhan logicalhan

@liggitt liggitt

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
8 participants
@serathius @fejta-bot @logicalhan @fedebongio @k8s-ci-robot @liggitt @lavalamp @MaciekPytel