Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #89741: Fix permissions for endpointslice controller #89804

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Automated cherry pick of #89741: Fix permissions for endpointslice controller #89804

merged 1 commit into from
Apr 7, 2020

Conversation

marun
Copy link
Contributor

@marun marun commented Apr 3, 2020 •
edited
Loading

Cherry pick of #89741 on release-1.18.

#89741: Fix permissions for endpointslice controller

For details on the cherry pick process, see the cherry pick requests page.

Fixed the EndpointSlice controller to run without error on a cluster with the OwnerReferencesPermissionEnforcement validating admission plugin enabled.

@marun
Fix permissions for endpointslice controller
1cf2fd1 
The controller needs to be able to set a service's finalizers to be
able to create an EndpointSlice resource that is owned by the service
and sets blockOwnerDeletion=true in its ownerRef.
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from deads2k and enj April 3, 2020 04:56
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 3, 2020
@marun
Copy link
Contributor Author

marun commented Apr 3, 2020

/cc @robscott @thockin

@k8s-ci-robot k8s-ci-robot requested review from robscott and thockin April 3, 2020 05:03
@robscott
Copy link
Member

robscott commented Apr 3, 2020

Thanks!

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2020
@robscott
Copy link
Member

robscott commented Apr 3, 2020 •
edited
Loading

/kind bug
/priority important-soon
/sig network

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 3, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 3, 2020

/retest

@robscott
Copy link
Member

robscott commented Apr 3, 2020

/assign @thockin

@robscott
Copy link
Member

robscott commented Apr 3, 2020

/retest

1 similar comment
@robscott
Copy link
Member

robscott commented Apr 4, 2020

/retest

thockin
thockin reviewed Apr 6, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 75b1354 into kubernetes:release-1.18 Apr 7, 2020
@robscott robscott mentioned this pull request Apr 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@deads2k deads2k Awaiting requested review from deads2k

@enj enj Awaiting requested review from enj

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
6 participants
@marun @robscott @spiffxp @k8s-ci-robot @thockin @tpepper