Clean up event messages for errors. #89794
Merged
+91
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
cc: @kubernetes/release-managers |
|
/retest |
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change-Id: Ib70b50e676b917c4d976f32ee7a19f8fc63b6bc6
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 4, 2020
…-upstream-release-1.18 Automated cherry pick of #89794: Clean up event messages for errors.
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 9, 2020
…-upstream-release-1.17 Automated cherry pick of #89794: Clean up event messages for errors.
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 9, 2020
…-upstream-release-1.16 Automated cherry pick of #89794: Clean up event messages for errors.
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 9, 2020
…-upstream-release-1.15 Automated cherry pick of #89794: Clean up event messages for errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Error output from some volume clients can be quite verbose. These messages currently propagate to Kubernetes events, which causes a bit of event spam. This change leaves the details to logs instead, and keeps the event message short.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: