-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the services web ui for nodeport and loadbalancer #8947
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
@lavalamp as a shot in the dark, please reassign as needed |
Thank you very much for the pull request - we sincerely appreciate the work that goes into sending us a change. We are currently in a feature-freeze and general code slush as we work toward our 1.0 release. Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0. We expect the freeze to wrap up in early to mid July. If you feel that this triage is incorrect, please respond and let us know why. We're currently accepting changes that meet any of the following criteria: Changes directly related to v1.0 issues: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+milestone%3Av1.0 |
@@ -3526,7 +3526,7 @@ app.controller('ListPodsCtrl', [ | |||
app.controller('ListReplicationControllersCtrl', [ | |||
'$scope', | |||
'$routeParams', | |||
'k8sApi', | |||
'k8sv1Beta3Api', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, you should be able to switch this to the v1 API which will be the default starting today.
648fe53
to
5fca9e3
Compare
I've updated the code with the indentation fix and labeling style change mentioned above. The v1 update is in a separate PR which this now depends on - PR #9408 |
LGTM |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Remove PublicIPs
5fca9e3
to
90b0b5c
Compare
@kprobst I've rebased. Is this going to make it in soon? |
Update the services web ui for nodeport and loadbalancer
This updates the web ui services page with the new fields shown in
kubectl describe service
.Currently depends on #8611 and #8612 which should be merged shortly.
This is also a part of the updates listed in #7122