Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the services web ui for nodeport and loadbalancer #8947

Merged
merged 1 commit into from
Jun 22, 2015

Conversation

bcbroussard
Copy link
Contributor

This updates the web ui services page with the new fields shown in kubectl describe service.

  • Added NodePort and Loadbalancer
  • Removed PublicIPs

Currently depends on #8611 and #8612 which should be merged shortly.

This is also a part of the updates listed in #7122

@k8s-bot
Copy link

k8s-bot commented May 28, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@thockin
Copy link
Member

thockin commented May 28, 2015

@lavalamp as a shot in the dark, please reassign as needed

@erictune
Copy link
Member

erictune commented Jun 1, 2015

Thank you very much for the pull request - we sincerely appreciate the work that goes into sending us a change.

We are currently in a feature-freeze and general code slush as we work toward our 1.0 release. Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0. We expect the freeze to wrap up in early to mid July.

If you feel that this triage is incorrect, please respond and let us know why. We're currently accepting changes that meet any of the following criteria:

Changes directly related to v1.0 issues: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+milestone%3Av1.0
Changes addressing P0 bugs: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Apriority%2FP0
Changes to supported platforms to bring them up to par with the primary development platforms
Docs, user experience, and test related fixes
Thanks again for your contribution! The community is really what has made this project so exciting.

@lavalamp lavalamp assigned kprobst and unassigned lavalamp Jun 5, 2015
@@ -3526,7 +3526,7 @@ app.controller('ListPodsCtrl', [
app.controller('ListReplicationControllersCtrl', [
'$scope',
'$routeParams',
'k8sApi',
'k8sv1Beta3Api',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, you should be able to switch this to the v1 API which will be the default starting today.

@bcbroussard
Copy link
Contributor Author

I've updated the code with the indentation fix and labeling style change mentioned above.

The v1 update is in a separate PR which this now depends on - PR #9408

@kprobst
Copy link

kprobst commented Jun 10, 2015

LGTM

@k8s-bot
Copy link

k8s-bot commented Jun 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@bcbroussard
Copy link
Contributor Author

@kprobst I've rebased. Is this going to make it in soon?

@kprobst kprobst added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2015
j3ffml added a commit that referenced this pull request Jun 22, 2015
Update the services web ui for nodeport and loadbalancer
@j3ffml j3ffml merged commit 1874599 into kubernetes:master Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants