Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NewAgnhostPod() to e2e/network #89387

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Move NewAgnhostPod() to e2e/network #89387

merged 1 commit into from
Mar 24, 2020

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Mar 23, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

because the function is called in e2e/network tests only and it is nice to move from util.go for reducing the code of util.go file.

Ref: #77095

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 23, 2020
@oomichi
Copy link
Member Author

oomichi commented Mar 23, 2020

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot requested review from bowei and krzyzacy March 23, 2020 23:46
@oomichi
Copy link
Member Author

oomichi commented Mar 23, 2020

According to https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/89387/pull-kubernetes-bazel-build/1242236102538956800/build-log.txt the failure seems unrelated to this PR as:

ERROR: /home/prow/go/src/github.com/kubernetes/kubernetes/cluster/images/conformance/BUILD:23:1: every rule of type container_push implicitly depends upon the target '@containerregistry//:pusher', but this target could not be found because of: no such package '@containerregistry//': java.io.IOException: Error downloading [https://github.com/google/containerregistry/archive/v0.0.34.tar.gz] to /bazel-scratch/.cache/bazel/_bazel_root/7989b31489f31aee54f32688da2f0120/external/containerregistry/v0.0.34.tar.gz: GET returned 401 UNAUTHORIZED
ERROR: Analysis of target '//cluster/images/conformance:push-conformance' failed; build aborted: no such package '@containerregistry//': java.io.IOException: Error downloading [https://github.com/google/containerregistry/archive/v0.0.34.tar.gz] to /bazel-scratch/.cache/bazel/_bazel_root/7989b31489f31aee54f32688da2f0120/external/containerregistry/v0.0.34.tar.gz: GET returned 401 UNAUTHORIZED

/test pull-kubernetes-bazel-build

gavinfish
gavinfish reviewed Mar 24, 2020
View reviewed changes
Copy link
Contributor

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm

test/e2e/network/util.go Outdated
@@ -21,9 +21,17 @@ import (
"fmt"
"time"

v1 "k8s.io/api/core/v1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: import alias with the same name does not help

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know that.
This part comes from the original one, I don't have strong opinion about that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a chance to update this PR.
So I am applying this your point into the latest PR.

@gavinfish
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
Move NewAgnhostPod() to e2e/network
5c77461 
because the function is called in e2e/network tests only.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@gavinfish
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@oomichi
Copy link
Member Author

oomichi commented Mar 24, 2020

/test pull-kubernetes-e2e-gce

@oomichi
Copy link
Member Author

oomichi commented Mar 24, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@oomichi
Copy link
Member Author

oomichi commented Mar 24, 2020

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 91766b8 into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinfish gavinfish gavinfish left review comments

@bowei bowei Awaiting requested review from bowei

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@gavinfish gavinfish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@oomichi @k8s-ci-robot @gavinfish @fejta-bot