Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] build: Enable kube-cross image-building on K8s Infra #88596

Merged
merged 3 commits into from
Feb 27, 2020
Merged

[1.16] build: Enable kube-cross image-building on K8s Infra #88596

merged 3 commits into from
Feb 27, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Feb 26, 2020 •
edited
Loading

Cherry pick of #88562 on release-1.16.
Required to allow referencing kube-cross images stored on K8s Infra.

#88562: build: Enable kube-cross image-building on K8s Infra

/kind feature cleanup
/sig release
/area release-eng
/priority important-soon

build: Enable kube-cross image-building on K8s Infra

For details on the cherry pick process, see the cherry pick requests page.

@justaugustus
build: Add OWNERS on build-image/
f887c67 
Here we're primarily concerned with the kube-cross image, though we
may expand scope at a later time.

Adding the following reviewers/approvers:
- BenTheElder
- cblecker
- dims
- justaugustus
- listx

Once we've defined policies for handling these images, we'll expand the
scope of this group to include Release Engineering.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
build: Add justaugustus as reviewer
4bd6612 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 26, 2020
@justaugustus justaugustus changed the title Automated cherry pick of #88562 upstream release 1.16 [1.16] build: Enable kube-cross image-building on K8s Infra Feb 27, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2020
@justaugustus
Copy link
Member Author

/assign @liggitt @cblecker @dims

@justaugustus
build: Enable kube-cross push/pull from K8s Infra GCR
4851f0f 
- Search/replace Google Infra kube-cross locations for K8s Infra
- Update kube-cross make targets
  - Don't attempt to pre-pull image (docker build --pull)
    This prevents CI failures when the image under test doesn't exist
    yet in the registry.
  - 'make all' now builds and pushes the kube-cross image
  - Allow 'TAG' to be specified via env var
  - Use 'KUBE_CROSS_VERSION' to represent the kube-cross version
  - Tag kube-cross images with both a kubernetes version
    ('git describe') and a kube-cross version
- Add a GCB (Google Cloud Build) config file (cloudbuild.yaml)

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus justaugustus force-pushed the automated-cherry-pick-of-#88562-upstream-release-1.16 branch from 6c9175d to 4851f0f Compare February 27, 2020 02:47
This was referenced Feb 27, 2020
Closed
Merged
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2020
@justaugustus justaugustus mentioned this pull request Feb 27, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Feb 27, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2020
@justaugustus
Copy link
Member Author

/remove-kind feature
/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed kind/feature Categorizes issue or PR as related to a new feature. labels Feb 27, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit ad22ce0 into kubernetes:release-1.16 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@ixdy ixdy Awaiting requested review from ixdy

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@liggitt liggitt

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @cblecker @liggitt @k8s-ci-robot @dims @tpepper