Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staticcheck: vendor/k8s.io/kubectl/pkg/scale etc. #87403

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Staticcheck: vendor/k8s.io/kubectl/pkg/scale etc. #87403

merged 2 commits into from
Feb 12, 2020

Conversation

gavinfish
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix static check failures for:

vendor/k8s.io/kubectl/pkg/cmd/top
vendor/k8s.io/kubectl/pkg/cmd/util/editor
vendor/k8s.io/kubectl/pkg/cmd/wait
vendor/k8s.io/kubectl/pkg/describe/versioned
vendor/k8s.io/kubectl/pkg/scale

Ref #81657

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @gavinfish. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 21, 2020
@k8s-ci-robot k8s-ci-robot requested review from hwdef and mengqiy January 21, 2020 02:26
@gavinfish
Copy link
Contributor Author

/assign @liggitt

@hwdef
Copy link
Member

hwdef commented Jan 21, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2020
@gavinfish
Copy link
Contributor Author

/retest

@YuikoTakada
Copy link
Contributor

you need to run ./hack/update-bazel.sh and apply the diff into this PR for passing pull-kubernetes-verify job.

@gavinfish
Copy link
Contributor Author

@YuikoTakada Thanks, I missed to commit the automated change.

@gavinfish
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Feb 7, 2020

lgtm, needs rebase

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2020
@gavinfish
Copy link
Contributor Author

/retest

1 similar comment
@gavinfish
Copy link
Contributor Author

/retest

@gavinfish
Copy link
Contributor Author

/retest

3 similar comments
@gavinfish
Copy link
Contributor Author

/retest

@gavinfish
Copy link
Contributor Author

/retest

@gavinfish
Copy link
Contributor Author

/retest

@gavinfish
Copy link
Contributor Author

@liggitt, thanks for reviewing, and rebase is done.

@liggitt
Copy link
Member

liggitt commented Feb 12, 2020

/lgtm
/approve
/test pull-kubernetes-bazel-build

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinfish, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit de9bbcc into kubernetes:master Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 12, 2020
@gavinfish gavinfish deleted the kubectl_pkg branch February 25, 2020 15:41
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#87403 from gavinfish/kubectl_pkg
eb1f9fd 
Staticcheck: vendor/k8s.io/kubectl/pkg/scale etc.

Kubernetes-commit: de9bbcc
@wking wking mentioned this pull request Aug 31, 2021
Merged
wking added a commit to wking/kubernetes that referenced this pull request Nov 17, 2021
@wking
kubectl: Document --for's Unicode case-folding condition-value compar…
f69d523 
…ison

When the wait command was added in 7679464 (add wait, 2018-05-18, kubernetes#64034),
this comparison was via ToLower.  It moved to use Unicode case folding
[1,2] in f4940cf (Staticcheck:
vendor/k8s.io/kubectl/pkg/scale|describe/versioned|cmd/top|cmd/util/editor|cmd/top,
2020-01-21, kubernetes#87403).

[1]: https://pkg.go.dev/strings#EqualFold
[2]: http://www.unicode.org/reports/tr30/tr30-1.html
yanghesong pushed a commit to yanghesong/kubernetes that referenced this pull request Jan 8, 2022
@wking @yanghesong
kubectl: Document --for's Unicode case-folding condition-value compar…
9d3ede4 
…ison

When the wait command was added in 7679464 (add wait, 2018-05-18, kubernetes#64034),
this comparison was via ToLower.  It moved to use Unicode case folding
[1,2] in f4940cf (Staticcheck:
vendor/k8s.io/kubectl/pkg/scale|describe/versioned|cmd/top|cmd/util/editor|cmd/top,
2020-01-21, kubernetes#87403).

[1]: https://pkg.go.dev/strings#EqualFold
[2]: http://www.unicode.org/reports/tr30/tr30-1.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef Awaiting requested review from hwdef

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@gavinfish @k8s-ci-robot @hwdef @YuikoTakada @liggitt