Make error message and service event message more clear #86078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
force-pushed
the
peni/fix-err-message
branch
from
eaee52e to
a9751c6
Compare
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/cloudprovider
approved
feiskyer
force-pushed
the
peni/fix-err-message
branch
from
a9751c6 to
96084a5
Compare
andyzhangx
reviewed
Dec 11, 2019
| message := "processHTTPRetryResponse: backoff failure, will retry" | ||
| if resp != nil { | ||
| message = fmt.Sprintf("%s, HTTP response: %d", message, resp.StatusCode) | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
if resp != nil && err != nil, then we only get second error msg, is that what you want? @feiskyer
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/sig cloud-provider
/area provider/azure
/priority important-soon
What this PR does / why we need it:
Azure cloud provider sometimes reports the following error, which is not clear:
In such cases, we should also log the HTTP response code, so that we could learn what's the real response from ARM API.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: