Apply resource versioning to list extractions from etcd #855
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but can you add a test? |
Set the resource version on lists of objects extracted from etcd to prevent them from always being interpreted as new during updates.
|
@lavalamp Done. |
|
LGTM, will merge when travis finishes. |
lavalamp
added a commit
that referenced
this pull request
Aug 11, 2014
Apply resource versioning to list extractions from etcd
|
Thanks for the fix! |
seans3
pushed a commit
to seans3/kubernetes
that referenced
this pull request
Apr 10, 2019
Proposal for adding headers with the command name to kubectl requests
b3atlesfan
pushed a commit
to b3atlesfan/kubernetes
that referenced
this pull request
Feb 5, 2021
make sure flanneld got QoS class "Guaranteed" to have lower oom_score_adj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the resource version on lists of objects extracted from etcd to prevent
them from always being interpreted as new during updates.