Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct confusing comment. #854

Merged
merged 1 commit into from
Aug 11, 2014
Merged

Correct confusing comment. #854

merged 1 commit into from
Aug 11, 2014

Conversation

lavalamp
Copy link
Member

Closes #853

@@ -87,7 +87,7 @@ func init() {
// registering all of these functions. Then, if you want to be able to understand
// v1beta1 objects, you just import that package for its side effects.
AddConversionFuncs(
// EnvVar's Name is depricated in favor of Key.
// EnvVar's Key is depricated in favor of Name.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix the typo too. It's "deprecate". :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lavalamp
Copy link
Member Author

Spelling corrected.

thockin added a commit that referenced this pull request Aug 11, 2014
Correct confusing comment.
@thockin thockin merged commit d5daea5 into kubernetes:master Aug 11, 2014
vishh pushed a commit to vishh/kubernetes that referenced this pull request Apr 6, 2016
b3atlesfan pushed a commit to b3atlesfan/kubernetes that referenced this pull request Feb 5, 2021
network: move ipmasq management into platform-specific files
DhritiShikhar pushed a commit to DhritiShikhar/kubernetes that referenced this pull request Aug 17, 2021
…fix-48

Bug 1957133: do not throw error when we can't get canonical path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is EnvVar.Key or EnvVar.Name deprecated (or both)?
3 participants