Disabling EndpointSlice feature gate by default #85365
Merged
+1
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/XS
|
I can't milestone this, but if someone can add v1.17 to this, that'd be super helpful. |
|
Thanks! /lgtm |
k8s-ci-robot
added
lgtm
Given the significance this change would have we've decided to hold off on enabling this by default until we can have better test coverage and more real world usage of the feature.
robscott
force-pushed
the
endpointslice-default-off
branch
from
5030d4d to
37aa219
Compare
k8s-ci-robot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/auth
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Given the significance this change would have along with some bugs that have surfaced recently, we've decided to hold off on enabling this by default until we can have better test coverage and more real world usage of the feature.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig network
/priority critical-urgent
/cc @thockin @liggitt @freehan