Watch delivers current state for resourceVersion=0 #852
Conversation
|
|
||
| // WatchAndTransform begins watching the specified key. Events are decoded into | ||
| // API objects and sent down the returned watch.Interface. If the transform | ||
| // function is provided, the value decoded from etcd will be passed to the function |
There was a problem hiding this comment.
just to be a pain - what is the transform function signature, and what is it supposed to do? Maybe a (textual) example?
There was a problem hiding this comment.
Woops, signature is just below. Still a bit more on the intended use would help
|
LGTM overall - need a second LG |
| go w.etcdWatch(h.Client, key, resourceVersion) | ||
| return w, nil | ||
| } | ||
|
|
||
| // TransformFunc attempts to convert an object to another object for use with a watcher | ||
| type TransformFunc func(interface{}) (interface{}, error) |
There was a problem hiding this comment.
It occurs to me now that TransformFunc and my own FilterFunc are actually better applied as a separate, layered watch.
e.g., in the watch package, func Filter(w Interface, f FilterFunc) Interface and func Transform(w Interface, f TransformFunc) Interface. Or they could even be combined, with FilterFunc returning the new object and whether to send it.
I can do that in another PR if you don't want to do it here.
There was a problem hiding this comment.
Agree - maybe follow on pull?
|
I think sendResult is not going to work with a list of nodes, which I think is what a recursive Get will return. Can you test that case, please? |
|
Yeah - or just don't offer the functionality on recursive Get? |
|
@smarterclayton: No I think the functionality is extremely important-- imagine a replicationController rebooting. That's broken right now without this. |
|
Working on it. |
|
ptal |
| } | ||
| copied := *response | ||
| copied.Node = node | ||
| glog.Infof("queueing change %#v", copied) |
Allows clients to get the current state without having to execute a get followed by a watch. Makes integration with action loops much cleaner.
|
LGTM |
Watch delivers current state for resourceVersion=0
Modify generic collector
Update node self-labeling implementation timeline
UPSTREAM: <carry>: add a way to inject a vulnerable, legacy service-c…
Allows clients to get the current state without having to execute
a get followed by a watch. Makes integration with action loops
much cleaner.
Split from #846