Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove the deprecated "--cri-socket" flag for "upgrade apply" #85044

Merged
merged 1 commit into from
Nov 11, 2019
Merged

kubeadm: remove the deprecated "--cri-socket" flag for "upgrade apply" #85044

merged 1 commit into from
Nov 11, 2019

Conversation

neolit123
Copy link
Member

What this PR does / why we need it:

Remove the flag "--cri-socket" from the "kubeadm upgrade apply"
command. It has been marked as deprecated since 1.14.

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1356

Special notes for your reviewer:
Are we OK removing this given the --config situation for upgrade apply?

Does this PR introduce a user-facing change?:

kubeadm: remove the deprecated "--cri-socket" flag for "kubeadm upgrade apply". The flag has been deprecated since v1.14.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @rosti @yastij
/priority important-longterm
/kind cleanup
/hold

@neolit123
kubeadm: remove the deprecated "--cri-socket" flag for "upgrade apply"
efc0ec5 
Remove the flag "--cri-socket" from the "kubeadm upgrade apply"
command. It has been marked as deprecated since 1.14.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 9, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2019
@rosti rosti mentioned this pull request Nov 9, 2019
Closed
2 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2019
yastij
yastij reviewed Nov 10, 2019
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2019
@ereslibre
Copy link
Contributor

I'm +1 for removing this flag.

/lgtm

Leaving hold cancel to @rosti.

fabriziopandini
fabriziopandini approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side

@neolit123
Copy link
Member Author

unholding tomorrow afternoon UTC.

rosti
rosti approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neolit123 !
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit fc0bf06 into kubernetes:master Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 11, 2019
@neolit123 neolit123 mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yastij yastij yastij left review comments

@fabriziopandini fabriziopandini fabriziopandini approved these changes

@rosti rosti rosti approved these changes

@ereslibre ereslibre Awaiting requested review from ereslibre

Assignees

@ereslibre ereslibre

@rosti rosti

@yastij yastij

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Deprecate and remove --cri-socket flag from kubeadm upgrade apply
6 participants
@neolit123 @k8s-ci-robot @ereslibre @rosti @fabriziopandini @yastij