Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify kubelet & kube-proxy recovery on Windows nodes #84886

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Verify kubelet & kube-proxy recovery on Windows nodes #84886

merged 1 commit into from
Dec 10, 2019

Conversation

YangLu1031
Copy link
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Add test cases to verify that kubelet & kube-proxy can recover after being killed on windows nodes.
Modify the test/e2e/apps/daemon_restart.go to support windows scenario.

Does this PR introduce a user-facing change?:

Verify kubelet & kube-proxy can recover after being killed on Windows nodes

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @YangLu1031. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YangLu1031
Copy link
Contributor Author

/cc pjh

@k8s-ci-robot k8s-ci-robot requested a review from pjh November 7, 2019 00:24
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2019
@pjh
Copy link
Contributor

pjh commented Nov 8, 2019

The new code LGTM. I think we'll need to modify the test configs as well to make this test run against Windows in our sig-windows test jobs. I don't remember if that's a k/k change or a test-infra change. Can you look into this?

@pjh
Copy link
Contributor

pjh commented Nov 8, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2019
@pjh
Copy link
Contributor

pjh commented Nov 8, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2019
@pjh
Copy link
Contributor

pjh commented Nov 8, 2019

cc @adelina-t @BCLAU

@YangLu1031
Copy link
Contributor Author

The new code LGTM. I think we'll need to modify the test configs as well to make this test run against Windows in our sig-windows test jobs. I don't remember if that's a k/k change or a test-infra change. Can you look into this?

Looks like we already have this test run on sig-windows test jobs: https://testgrid.k8s.io/sig-windows#gce-windows-1.17, "DaemonRestart [Disruptive]"

@YangLu1031
Copy link
Contributor Author

@pjh can you take a look again?

@pjh
Copy link
Contributor

pjh commented Nov 12, 2019

We can submit this now and then follow-up with changes to the test configs to get it running continuously for Windows.

/lgtm

@soltysh @kow3ns could you please take a look and approve? This change should be a no-op for existing Linux test runs.

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 12, 2019
@YangLu1031
Copy link
Contributor Author

/assign soltysh kow3ns

@YangLu1031
Copy link
Contributor Author

ping @soltysh @kow3ns for approval

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2019
@YangLu1031
Copy link
Contributor Author

@pjh Changed the 2 tests to Conformance test, so that they can show up on windows-gce-serial testgrid

@johnbelamaric
Copy link
Member

Thanks for the PR, but these cannot be conformance tests. These are implementation specifics. There is no reason a given distribution needs to run either of these processes, as long as they can provide the functionality of the cluster without them (kube-proxy in particular is quite replaceable).

@YangLu1031 YangLu1031 mentioned this pull request Dec 3, 2019
Merged
@YangLu1031
Copy link
Contributor Author

@pjh changed back to normal test

@YangLu1031
Copy link
Contributor Author

/cc @janetkuo Could you help to take a look? This small PR has been almost a month.

@pjh
Copy link
Contributor

pjh commented Dec 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@YangLu1031
Copy link
Contributor Author

/cc erictune

@k8s-ci-robot k8s-ci-robot requested a review from erictune December 3, 2019 02:25
@YangLu1031
Copy link
Contributor Author

/assign @erictune @janetkuo

@janetkuo
Copy link
Member

janetkuo commented Dec 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, YangLu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 78c56e6 into kubernetes:master Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjh pjh pjh left review comments

@janetkuo janetkuo janetkuo approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@soltysh soltysh Awaiting requested review from soltysh

@erictune erictune Awaiting requested review from erictune

Assignees

@pjh pjh

@soltysh soltysh

@janetkuo janetkuo

@erictune erictune

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
9 participants
@YangLu1031 @k8s-ci-robot @pjh @johnbelamaric @janetkuo @fejta-bot @soltysh @erictune @kow3ns