Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[migration phase 1] VolumeZoneChecker as filter plugin #83843

Merged
merged 1 commit into from
Oct 14, 2019
Merged

[migration phase 1] VolumeZoneChecker as filter plugin #83843

merged 1 commit into from
Oct 14, 2019

Conversation

notpad
Copy link
Contributor

@notpad notpad commented Oct 12, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add a filter plugin that calls into VolumeZoneChecker predicate
Which issue(s) this PR fixes:

Fixes #83634

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @notpad. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 12, 2019
@notpad notpad force-pushed the feature/migration_volumezone branch from f5c14e9 to 88bfdb7 Compare October 12, 2019 14:30
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2019
@notpad
Copy link
Contributor Author

notpad commented Oct 12, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2019
@wgliang
Copy link
Contributor

wgliang commented Oct 13, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2019
@notpad
Copy link
Contributor Author

notpad commented Oct 13, 2019

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-e2e-gce

@notpad
Copy link
Contributor Author

notpad commented Oct 13, 2019

/assign @k82cn
/cc @ahg-g

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g October 13, 2019 14:21
ahg-g
ahg-g reviewed Oct 13, 2019
View reviewed changes
Copy link
Member

@ahg-g ahg-g left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few bits, thanks for for doing this one.

pkg/scheduler/framework/plugins/volumezone/volume_zone_test.go Outdated
}
}

func TestVolumeZonePredicateMultiZone(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to TestMultiZone

pkg/scheduler/framework/plugins/volumezone/volume_zone_test.go Outdated
}
}

func TestVolumeZonePredicate(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to TestSingleZone

pkg/scheduler/framework/plugins/volumezone/volume_zone_test.go Outdated
}
}

func TestVolumeZonePredicateWithVolumeBinding(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to TestWithBinding

@ahg-g
Copy link
Member

ahg-g commented Oct 13, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, notpad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 13, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2019
@notpad notpad force-pushed the feature/migration_volumezone branch from 88bfdb7 to 881bbc6 Compare October 13, 2019 23:40
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 13, 2019
@notpad notpad force-pushed the feature/migration_volumezone branch from 881bbc6 to 4ff7251 Compare October 13, 2019 23:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2019
@notpad
Copy link
Contributor Author

notpad commented Oct 14, 2019

/test pull-kubernetes-integration

@ahg-g
Copy link
Member

ahg-g commented Oct 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 14, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 14, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit a0193ac into kubernetes:master Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 14, 2019
ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
@k8s-ci-robot @ohsewon
Merge pull request kubernetes#83843 from notpad/feature/migration_vol…
129742a 
…umezone

[migration phase 1] VolumeZoneChecker as filter plugin
@notpad notpad mentioned this pull request Oct 16, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@k82cn k82cn

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

[migration phase 1] VolumeZoneChecker as filter plugin
5 participants
@notpad @k8s-ci-robot @wgliang @ahg-g @k82cn