Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prometheus reference from storage #83678

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Remove prometheus reference from storage #83678

merged 2 commits into from
Oct 14, 2019

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind feature
/priority important-soon

What this PR does / why we need it:
Remove direct reference to Prometheus.

To get metrics stability into Beta, we will make it illegal to directly import prometheus methods in Kubernetes components.

Which issue(s) this PR fixes:
Refer kubernetes/enhancements#1238

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2019
@RainbowMango
Copy link
Member Author

/assign @lavalamp

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2019
@roycaihw
Copy link
Member

/cc @wenjiaswe @jktomer

@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: jktomer.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @wenjiaswe @jktomer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jktomer
Copy link

jktomer commented Oct 10, 2019

LGTM (but mine doesn't count yet, you'll need an /lgtm from someone else)

@RainbowMango
Copy link
Member Author

ping @lavalamp and
/assign @wojtek-t

#83837 rely on this.

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2019
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-dependencies
Can't access the logs.

@RainbowMango RainbowMango force-pushed the pr_remove_prometheus_reference_from_storage branch from ee9ed5a to 53f448f Compare October 14, 2019 12:03
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019
@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019
@RainbowMango
Deal with auto-generated files.
6764bf3 
- Update bazel by hack/update-bazel.sh
- Update vendor by hack/update-vendor.sh
@RainbowMango RainbowMango force-pushed the pr_remove_prometheus_reference_from_storage branch from 53f448f to 6764bf3 Compare October 14, 2019 12:11
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 14, 2019
@RainbowMango
Copy link
Member Author

@wojtek-t
I made a mistake in last fore push(forgot add vendor-related changes).

This should be fine.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

RainbowMango
RainbowMango commented Oct 14, 2019
View reviewed changes
staging/src/k8s.io/apiserver/go.mod
@@ -29,7 +29,6 @@ require (
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822
github.com/pborman/uuid v1.2.0
github.com/pquerna/cachecontrol v0.0.0-20171018203845-0dec1b30a021 // indirect
github.com/prometheus/client_golang v0.9.4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI:
Removed this line making robot happy.

@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2019
@RainbowMango RainbowMango mentioned this pull request Oct 14, 2019
Closed
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit f7992c7 into kubernetes:master Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 14, 2019
@RainbowMango RainbowMango deleted the pr_remove_prometheus_reference_from_storage branch October 15, 2019 01:15
ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
@k8s-ci-robot @ohsewon
Merge pull request kubernetes#83678 from RainbowMango/pr_remove_prome…
ac3ead9 
…theus_reference_from_storage

Remove prometheus reference from storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgrzadkowski fgrzadkowski Awaiting requested review from fgrzadkowski

@mqliang mqliang Awaiting requested review from mqliang

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@lavalamp lavalamp

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
6 participants
@RainbowMango @roycaihw @k8s-ci-robot @jktomer @wojtek-t @lavalamp