Migrate prometheus bucket functionality to metrics stability framework for apiserver #82630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
area/dependency
|
/assign @logicalhan |
20 tasks
RainbowMango
force-pushed
the
pr_migrate_prom_bucket_for_apiserver
branch
from
b807068 to
1f9ab1b
Compare
|
/test pull-kubernetes-bazel-test |
Update vendor by hack/update-vendor.sh
RainbowMango
force-pushed
the
pr_migrate_prom_bucket_for_apiserver
branch
from
f09fcd4 to
764e6a6
Compare
|
/test pull-kubernetes-bazel-build |
|
/test pull-kubernetes-bazel-build |
|
/assign @liggitt |
|
/unassign this is good for @logicalhan to review |
|
/priority important-soon |
k8s-ci-robot
added
the
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
Fine, let's wait for @logicalhan review. Thanks for quick response. |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ohsewon
pushed a commit
to ohsewon/kubernetes
that referenced
this pull request
Oct 16, 2019
…_bucket_for_apiserver Migrate prometheus bucket functionality to metrics stability framework for apiserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR migrate prometheus bucket to metrics stability framework.
The metrics stability framework has provided bucket functionality. (refer: #82583)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @sttts