-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for dirty files is not accurate #826
Conversation
@@ -1,5 +1,7 @@ | |||
#!/bin/bash | |||
|
|||
echo "foo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug code?
Facepalm |
LGTM; should someone else give this a try before we merge? |
I think so |
I can test this and report back. |
@derekwaynecarr did you end up trying this? |
@lavalamp @smarterclayton - I tried this. I think the message echo to terminal is no longer accurate with the observed results. The script refused to update anything if I had anything in my git status results - even if the content was untracked by git and never staged for commit. I see that we ignore .gitignore content in this update, but if the desire is to inspect untracked files as well, we should clarify that in the echo comment. |
Untracked content should probably be flagged because the script runs |
@smarterclayton its not uncommon for me to keep a temp file in my workspace that has notes on the thing i am working on. It's not a major issue for me to require a clean workspace, just make the comment state that clearly "Before updating third-pary code, you must have no staged or untracked files (i.e. git status returns no results)." |
grep '^M' was not returning anything. In general diff-index and ls-files are preferred to status --porcelain.
@derekwaynecarr I made it only check for unclean files in third_party/src |
LGTM |
Check for dirty files is not accurate
Improve cloud provider docs KEP
kube-flannel.yaml: Update manifests to latest release
…rry-pick-804-to-release-4.7 [release-4.7] Bug 1975553: only chown if non-windows machine with projected volumes
grep '^M' was not returning anything. In general diff-index and
ls-files are preferred to status --porcelain.
Could use some testing.