-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose user info to admission controllers #8203
Expose user info to admission controllers #8203
Conversation
I have no issue adding this, but I think we need to make careful usage of it. I will refer to: Your scenario is not fully captured in this PR, but it appears that at the moment, if an admission decision is tied to the Moving forward, I would like to know how we can log the necessary information to allow the same pattern to be supported as an initializer post Kube 1.0 that can run prior to scheduling. For example, if we had access to an audit log of who did what to what resource, could that be coupled to do the right thing in a latent initializer for the future scenario. |
Yeah, or how can context be passed remotely. Can we not just add explicit user info to the admission context?
|
Agree with Clayton, add what you explicitly need rather than full context so we know what on the context is actually used as we move scenario to some type of controller post 1.0 Sent from my iPhone
|
Sure, will update to only pass |
73c9050
to
aaeb1da
Compare
I like this change and I need it in OpenShift to support securing access to service accounts. |
LGTM, will give the day before merging for any other comments. |
Merging |
Expose user info to admission controllers
Expose the context to admission controllers via the Attributes record
Use case: For systems built on top of Kubernetes that have authorizers admission controllers have the ability to make decisions based on the
user.Info
object available from the context. https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/context.go#L100@derekwaynecarr @smarterclayton @erictune @pmorie @liggitt @deads2k