Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cAdvisor godeps to v0.34.0 release #81972

Merged
merged 1 commit into from
Aug 30, 2019
Merged

update cAdvisor godeps to v0.34.0 release #81972

merged 1 commit into from
Aug 30, 2019
+49 −6

Conversation

dashpole
Copy link
Contributor

What type of PR is this?
/kind bug
Since this version bump contains at least one bugfix.

What this PR does / why we need it:
cAdvisor cuts a release for each kubernetes release. This is the cAdvisor release update for kubernetes 1.16.

Which issue(s) this PR fixes:
Fixes #81228

Does this PR introduce a user-facing change?:

- Fix disk stats in LXD using ZFS storage pool
- Fix CRI-O missing network metris bug
- Add `container_sockets`, `container_threads`, and `container_threads_max` metrics

/assign @dchen1107

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from dchen1107, liggitt and a team August 26, 2019 23:24
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Aug 26, 2019
@dashpole
Copy link
Contributor Author

/priority important-soon
/sig node

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2019
@dims
Copy link
Member

dims commented Aug 26, 2019

/approve
/lgtm

/assign @liggitt @smarterclayton
(for root approval)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2019
@dashpole
Copy link
Contributor Author

@liggitt as someone who had to deal with many dependency nightmares with cAdvisor, I was very impressed with how easy it was to use go modules for this dependency update.
Thanks a bunch!

@dashpole
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Aug 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@dashpole dashpole mentioned this pull request Aug 27, 2019
Closed
@liggitt liggitt added this to the v1.16 milestone Aug 29, 2019
@dims
Copy link
Member

dims commented Aug 30, 2019

ugh. needs rebase @dashpole

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@dashpole
Copy link
Contributor Author

@dims rebased. Needs lgtm reapplied.

@liggitt
Copy link
Member

liggitt commented Aug 30, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit fe770ad into kubernetes:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@liggitt liggitt

@smarterclayton smarterclayton

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Cut and vendor cAdvisor release for 1.16
7 participants
@dashpole @dims @liggitt @k8s-ci-robot @cblecker @smarterclayton @dchen1107