added ISCSI volume plugin to PersistentVolumeSource #8133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quick scan LGTM. still @ArtfulCoder for more detail |
|
@ArtfulCoder PTAL? Thanks! |
|
Rebased, generated conversions, and fixed a missing PV support thing in CanSupport func. @ArtfulCoder PTAL? This should be good to go. |
|
Abhi is out for a few days, sorry. |
|
LGTM |
smarterclayton
added
the
lgtm
thockin
added a commit
that referenced
this pull request
May 27, 2015
added ISCSI volume plugin to PersistentVolumeSource
|
This is breaking travis now, it doesn't have generated funds. |
|
"deep copy funcs" |
|
Looking into it. |
|
Got them. I'll send another PR for the generated funcs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt. Previous attempt #7734.
@ArtfulCoder better luck this time?