Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce GCE PD Attach Limits by 1 because Node Boot Disk counts as 1 attached disk #80923

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Reduce GCE PD Attach Limits by 1 because Node Boot Disk counts as 1 attached disk #80923

merged 1 commit into from
Aug 3, 2019

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Aug 2, 2019 •
edited
Loading

PD CSI Driver xref: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#361
Fixes: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#360
Original issue uncovered by: #80247

Should probably be cherry-picked appropriately since this is a bug that will manifest since attach limits introduced

/assign @msau42 @jsafrane

/kind bug

Reduces GCE PD Node Attach Limits by 1 since the node boot disk is considered an attachable disk

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 2, 2019
@davidz627
Copy link
Contributor Author

/kind bug
/sig storage
/cc @gnufied
/priority important-soon

@k8s-ci-robot k8s-ci-robot requested a review from gnufied August 2, 2019 20:40
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 2, 2019
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and verult August 2, 2019 20:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@davidz627
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2019
@msau42
Copy link
Member

msau42 commented Aug 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2019
@gnufied
Copy link
Member

gnufied commented Aug 2, 2019

looks good to me too! we already do this for AWS and on AWS in fact we leave more than one disk to account for boot disk and may be disk for docker setup. many installations that use overlay2 prefer their own disk for docker

@davidz627
Copy link
Contributor Author

/hold cancel
just tested again to confirm the 16 disk case as well with a shared core machine, this PR is valid

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2019
This was referenced Aug 2, 2019
Merged
Merged
@davidz627 davidz627 mentioned this pull request Aug 2, 2019
Merged
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 5c16a78 into kubernetes:master Aug 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 3, 2019
@davidz627 davidz627 deleted the fix/pdAttachLimit branch August 5, 2019 19:02
k8s-ci-robot added a commit that referenced this pull request Aug 7, 2019
@k8s-ci-robot
Merge pull request #80926 from davidz627/automated-cherry-pick-of-#80…
aaaf6d4 
…923-upstream-release-1.14

Automated cherry pick of #80923: Reduce GCE PD Attach Limits by 1 because Node Boot Disk
k8s-ci-robot added a commit that referenced this pull request Aug 7, 2019
@k8s-ci-robot
Merge pull request #80925 from davidz627/automated-cherry-pick-of-#80…
e8f84b2 
…923-upstream-release-1.15

Automated cherry pick of #80923: Reduce GCE PD Attach Limits by 1 because Node Boot Disk
k8s-ci-robot added a commit that referenced this pull request Aug 8, 2019
@k8s-ci-robot
Merge pull request #80927 from davidz627/automated-cherry-pick-of-#80…
48844ef 
…923-upstream-release-1.13

Automated cherry pick of #80923: Reduce GCE PD Attach Limits by 1 because Node Boot Disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

@verult verult Awaiting requested review from verult

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Reserve attach capacity for a boot disk
6 participants
@davidz627 @k8s-ci-robot @msau42 @gnufied @fejta-bot @jsafrane