Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/volume/portworx: Update vendor for libopenstorage/openstorage to v1.0.0 #80495

Merged
merged 2 commits into from
Jul 26, 2019
Merged

pkg/volume/portworx: Update vendor for libopenstorage/openstorage to v1.0.0 #80495

merged 2 commits into from
Jul 26, 2019

Conversation

adityadani
Copy link
Contributor

@adityadani adityadani commented Jul 23, 2019 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
vendor: update for libopenstorage/openstorage to v1.0.0

  • Portworx storage plugin under pkg/volume/portworx uses the libopenstorage/openstorage dependency.
  • This change does not update any of the go files vendor'ed from libopenstorage/openstorage but simply updates the go modules vendor from a SHA to the v1.0.0 tag.

This PR addresses action item 2 and 3, and partially address action item 1 from this comment:
#80281 (comment)

Which issue(s) this PR fixes:
Fixes #80029

Special notes for your reviewer:
The changes are divided into two commits:

  1. Updates the dependencies to use tag v1.0.0 instead of a sha to libopenstorage/openstorage
  2. Update the OWNERS for pkg/volume/portworx

Does this PR introduce a user-facing change?:

Update portworx plugin dependency on libopenstorage/openstorage to v1.0.0

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig storage
/area code-organization

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @adityadani. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from rootfs, smarterclayton and a team July 23, 2019 23:11
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jul 23, 2019
@adityadani
Copy link
Contributor Author

/assign @dims

@adityadani adityadani mentioned this pull request Jul 23, 2019
Closed
@adityadani
Copy link
Contributor Author

cc @lpabon @saad-ali

@adityadani adityadani force-pushed the update_openstorage_to_v1.0.0 branch from d8d769f to 9942eb9 Compare July 23, 2019 23:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2019
@saad-ali
Copy link
Member

/assign

Discussion k8s membership offline with @adityadani and @lpabon

@adityadani adityadani force-pushed the update_openstorage_to_v1.0.0 branch from 9942eb9 to 9dae95d Compare July 24, 2019 00:38
@dims
Copy link
Member

dims commented Jul 24, 2019

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2019
@dims
Copy link
Member

dims commented Jul 24, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 24, 2019
@lpabon
Copy link
Contributor

lpabon commented Jul 24, 2019

/retest

1 similar comment
@lpabon
Copy link
Contributor

lpabon commented Jul 24, 2019

/retest

@dims
Copy link
Member

dims commented Jul 25, 2019

/approve
/lgtm

@adityadani once @lpabon accepts the org membership, please rebase this to get rid of do-not-merge/invalid-owners-file

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@lpabon
Copy link
Contributor

lpabon commented Jul 25, 2019

/approve

@lpabon
Copy link
Contributor

lpabon commented Jul 25, 2019

/assign @thockin

@adityadani
vendor: update for libopenstorage/openstorage to v1.0.0
d647063 
- Portworx storage plugin under pkg/volume/portworx uses the libopenstorage/openstorage dependency.
- This change does not update any of the go files vendor'ed from libopenstorage/openstorage but simply
  updates the go modules vendor from a SHA to the v1.0.0 tag.
@adityadani
Update pkg/volume/portworx OWNERs
ab72c09
@adityadani adityadani force-pushed the update_openstorage_to_v1.0.0 branch from 9dae95d to ab72c09 Compare July 25, 2019 21:40
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 25, 2019
@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2019
@lpabon
Copy link
Contributor

lpabon commented Jul 25, 2019

/approve

@dims
Copy link
Member

dims commented Jul 25, 2019

/assign @thockin @liggitt
/approve
/lgtm

Tim, Jordan, easy one, no change in code, the random SHA was tagged as 1.0.0, needs root OWNERS approval

@liggitt
Copy link
Member

liggitt commented Jul 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adityadani, dims, liggitt, lpabon, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@dims
Copy link
Member

dims commented Jul 26, 2019

/test pull-kubernetes-integration

@dims
Copy link
Member

dims commented Jul 26, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit de73f62 into kubernetes:master Jul 26, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@rootfs rootfs Awaiting requested review from rootfs

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@liggitt liggitt

@thockin thockin

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Update libopenstorage/openstorage dependency to a release version
9 participants
@adityadani @k8s-ci-robot @saad-ali @dims @lpabon @liggitt @fejta-bot @neolit123 @thockin