Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds kubeadm feature-gate for dual-stack (IPv6DualStack) #80145

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Adds kubeadm feature-gate for dual-stack (IPv6DualStack) #80145

merged 1 commit into from
Jul 15, 2019

Conversation

Arvinderpal
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds the dual-stack feature gate to kubeadm. We need to isolate the forthcoming dual-stack related changes to kubeadm.

Special notes for your reviewer:
This is the first of several PRs that will bring dual-stack specific changes to kubeadm. For a complete list of kubeadm changes, see the tracking issue: kubernetes/kubeadm#1612

Does this PR introduce a user-facing change?:

kubeadm ClusterConfiguration now supports featureGates: IPv6DualStack: true

@neolit123 @yastij @fabriziopandini @aojea

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Arvinderpal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2019
@k8s-ci-robot k8s-ci-robot requested review from dixudx and yagonobre July 14, 2019 19:11
neolit123
neolit123 reviewed Jul 14, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Arvinderpal , added one comment about importing /pkg

@kubernetes/sig-cluster-lifecycle-pr-reviews
/priority important-longterm

i requested this PR and it only serves the purpose of adding the FG + release note.

cmd/kubeadm/app/features/features.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/features/features.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2019
yastij
yastij suggested changes Jul 14, 2019
View reviewed changes
cmd/kubeadm/app/features/features.go Outdated Show resolved Hide resolved
@Arvinderpal Arvinderpal force-pushed the kubeadm-ds-feature-gate branch from 2117142 to 79e7a4c Compare July 15, 2019 02:45
@Arvinderpal
Copy link
Contributor Author

@neolit123 @yastij
I made the requested changes.

@Arvinderpal Arvinderpal mentioned this pull request Jul 15, 2019
Closed
14 tasks
@fabriziopandini
Copy link
Member

/ok-to-test
I'm still not 100% convinced we need a dual-stack flag as per comment #79033 (review).
However, If the majority is ok with this, I'm fine with that.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2019
@neolit123
Copy link
Member

neolit123 commented Jul 15, 2019 •
edited
Loading

/hold

@fabriziopandini

I'm still not 100% convinced we need a dual-stack flag as per comment #79033 (review).

Kubeadm feature flags are different from components feature flags.
I don't think we should add a new feature flag in kubeadm specific for dual stack; nevertheless, I would like to add a validation check that ensures the configuration is consistent in case that when the users opt-in into dual stack, or blocks if the users are providing inconsistent configurations. e.g. Pass if there are two subnets in all the required settings, feature flags are enabled for core components etcd.

so instead of the kubeadm FG, we should tell the users (document) how to enable it by passing the k8s FG to all the required components?

@Arvinderpal which components are going to support the k8s FG?
(my guess is all of them?)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
neolit123
neolit123 reviewed Jul 15, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arvinderpal, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 768acf6 into kubernetes:master Jul 15, 2019
@neolit123 neolit123 mentioned this pull request Jul 16, 2019
Merged
1 task
@Arvinderpal Arvinderpal mentioned this pull request Jul 24, 2019
Merged
Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 30, 2019
@Arvinderpal
Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
585ef37 
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612
@Arvinderpal Arvinderpal mentioned this pull request Nov 27, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@yastij yastij yastij requested changes

@dixudx dixudx Awaiting requested review from dixudx

@yagonobre yagonobre Awaiting requested review from yagonobre

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Arvinderpal @k8s-ci-robot @fabriziopandini @neolit123 @yastij