Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update code docs around old todo that is not going to happen #79892

Merged
merged 1 commit into from
Jul 11, 2019
Merged

update code docs around old todo that is not going to happen #79892

merged 1 commit into from
Jul 11, 2019

Conversation

mikebrow
Copy link
Member

@mikebrow mikebrow commented Jul 8, 2019

Going through old TODOs to clean up kubelet. I see there was a todo to remove normalization of cached timestamps when issue #15262 and pr #15263 merged, but they were closed 4years ago. Time to remove the TODO and update the code documentation to reflect.

@Random-Liu

Signed-off-by: Mike Brown brownwm@us.ibm.com

/kind cleanup

na

@mikebrow
update code docs around old todo that is not going to happen
7b6bb58 
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from krmayankk and resouer July 8, 2019 14:35
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 8, 2019
mattjmcnaughton
mattjmcnaughton approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for this clean up :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2019
@mattjmcnaughton
Copy link
Contributor

/assign @tallclair
/test pull-kubernetes-e2e-gce-100-performance

@tallclair
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikebrow, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b168ab1 into kubernetes:master Jul 11, 2019
@saschagrunert saschagrunert mentioned this pull request Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton mattjmcnaughton approved these changes

@krmayankk krmayankk Awaiting requested review from krmayankk

@resouer resouer Awaiting requested review from resouer

Assignees

@mattjmcnaughton mattjmcnaughton

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikebrow @mattjmcnaughton @tallclair @k8s-ci-robot @fejta-bot